Skip to content

Fixes to ElfFile to be able to save a core file. #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

Fixes to ElfFile to be able to save a core file. #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/LibObjectFile/Elf/ElfFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ public sealed partial class ElfFile : ElfObject, IEnumerable<ElfContent>
/// <summary>
/// Creates a new instance with the default sections (null and a shadow program header table).
/// </summary>
public ElfFile(ElfArch arch) : this(arch, ElfFileClass.None, ElfEncoding.None)
public ElfFile(ElfArch arch, bool addDefaultSections=true) : this(arch, ElfFileClass.None, ElfEncoding.None, addDefaultSections)
{
}

/// <summary>
/// Creates a new instance with the default sections (null and a shadow program header table).
/// </summary>
public ElfFile(ElfArch arch, ElfFileClass fileClass, ElfEncoding encoding) : this(true)
public ElfFile(ElfArch arch, ElfFileClass fileClass, ElfEncoding encoding,bool addDefaultSections=true) : this(addDefaultSections)
{
Arch = arch;
switch (arch)
Expand Down
5 changes: 5 additions & 0 deletions src/LibObjectFile/Elf/ElfProgramHeaderTable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ public override void Verify(ElfVisitorContext context)

protected override unsafe void UpdateLayoutCore(ElfVisitorContext context)
{
var elf = Parent;
if (elf != null)
{
_is32 = elf.FileClass == ElfFileClass.Is32;
}
Size = (ulong)(Parent!.Segments.Count * (AdditionalEntrySize + (_is32 ? sizeof(ElfNative.Elf32_Phdr) : sizeof(ElfNative.Elf64_Phdr))));
}

Expand Down