Skip to content

Conversation

messani
Copy link
Contributor

@messani messani commented Jul 14, 2025

Fixes #881

Adds source position tracking for grid tables and corresponding tests.


ContinueProcessingLine = true;

ResetLine(newLine, 0);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ResetLine(newLine, 0);
ResetLine(newLine, column);

Shouldn't it pass column?

@messani
Copy link
Contributor Author

messani commented Jul 14, 2025

Sorry about that — the first fix for this issue was a bit of a hack, and part of that code was left behind. It shouldn't have affected functionality, but it wasn't clean. I've corrected it now, and it should be fine. Thanks for spotting it!

@messani
Copy link
Contributor Author

messani commented Jul 14, 2025

Since I'm not the original author, my contribution might not be entirely ideal.
The original ProcessLine method works the same way as before.
I've introduced a new method, ProcessLinePart, which doesn't add an entry to the LineStartIndexes variable and doesn't increment LineIndex.
Unfortunately, I'm not entirely sure how the BlockProcessor is designed internally, so I hope this change doesn't cause any issues.

@xoofx xoofx merged commit 2aa6780 into xoofx:master Aug 28, 2025
@xoofx
Copy link
Owner

xoofx commented Aug 28, 2025

Thanks for this. As I have been quite away from the details on this project, I will have to double check things, but it looks ok. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Line/Column positions inside GridTable
2 participants