Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clients from dist #186

Merged
merged 5 commits into from
Feb 14, 2025
Merged

Clients from dist #186

merged 5 commits into from
Feb 14, 2025

Conversation

GermanVor
Copy link

No description provided.

@GermanVor GermanVor requested a review from DavyJohnes January 28, 2025 11:12
@@ -16,6 +15,7 @@ import {
import { initOperationSdk } from '@yandex-cloud/nodejs-sdk/dist/sdk/operation';

import { readFile } from 'fs/promises';
import { ExpirationConfig_ExpirationPolicy } from '@yandex-cloud/nodejs-sdk/dist/generated/yandex/cloud/ai/common/common';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выглядит не очень. Надо как-то научиться реэкспортить все сущности связанные с сервисом в index модуль сервиса.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

да, кажется можно допилить скрипт, чтобы он затем ходил рекурсивно по всем файлам из /src/clients/service-name/index.ts и добавлял экспорты в /src/clients/service-name/index.ts - коллизии имен можно будет решить через уже имеющийся export-alias.json

я бы в другом пр это исследовал, а пока что можно сделать так - это выглядит логично и очень дешево

48e05d9

@@ -11,6 +11,8 @@
"license": "ISC",
"dependencies": {
"@yandex-cloud/nodejs-sdk": "../",
"dotenv": "^16.4.7",
"ts-node": "^10.9.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не вижу где используются и тот и другой...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavyJohnes DavyJohnes merged commit 817330c into alpha Feb 14, 2025
3 of 4 checks passed
@yandex-cloud-bot
Copy link
Collaborator

🎉 This PR is included in version 3.0.0-alpha.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants