Discover endpoints #188
Merged
Discover endpoints #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavyJohnes
reviewed
Feb 14, 2025
package.json
Outdated
| @@ -88,7 +88,8 @@ | |||
| "typecheck:src": "tsc --noEmit -p ./tsconfig.prod.json", | |||
| "typecheck:examples": "tsc --noEmit -p ./examples/tsconfig.json", | |||
| "typecheck": "npm run typecheck:src && npm run typecheck:examples", | |||
| "cloudapi:update": "git submodule update --remote" | |||
| "cloudapi:update": "git submodule update --remote", | |||
| "discover_endpoints": "ts-node scripts/discover_endpoints" | |||
There was a problem hiding this comment.
Давай придерживаться какого-то консистентного нейминга?)
<subsystem>:<action>
В данном случае предлагаю cloudapi:discover-endpoints.
generate_services можно под этот же шаблон подогнать.
There was a problem hiding this comment.
discover-endpoints никак не взаимодействует с cloudapi
tsconfig.json
Outdated
| "strict": true, | ||
| "skipLibCheck": true, | ||
| "resolveJsonModule": true, | ||
| "lib": ["ES2021", "DOM"], |
There was a problem hiding this comment.
fetch же часть nodejs api, зачем DOM то?)
There was a problem hiding this comment.
fetch же часть nodejs api - нет, это браузерный сахар
There was a problem hiding this comment.
- Можно обновить
@types/nodeдо 18, там уже есть fetch-api. - В проекте есть
axios.
GermanVor
force-pushed
the
discover_endpoints
branch
from
6b3d260 to
7ef96e4
Compare
|
🎉 This PR is included in version 3.0.0-alpha.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.