chore(deps): do not pin deps in Cargo.toml #584
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From my understanding with this change, the CI could be randomly red because it checks that the Cargo.lock is never overridden by the Cargo.toml . |
dartdart26
force-pushed
the
petar/txn-sender-aws-kms
branch
from
a77c34d to
682ffd9
Compare
Instead, rely on Cargo.lock for pinning versions. Also, update otel to 0.29 and redo the code as it no longer compiles. Add the aws-sdk-kms and rstest dependencies for use in the transaction-sender. Specify more common dependencies in the workspace Cargo.toml file.
dartdart26
force-pushed
the
petar/txn-sender-aws-kms
branch
from
682ffd9 to
49bf42c
Compare
What do you mean by the CI check? I assume if there's no |
|
I will update dependencies with x.y.z versions instead of just x.y. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, rely on Cargo.lock for pinning versions.
Also, update otel to 0.29 and redo the code as it no longer compiles.
Specify more common dependencies in the workspace Cargo.toml file.