-
Notifications
You must be signed in to change notification settings - Fork 41
sam0: dac: Rename EMPTY bit-fields to avoid name collision. #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nandojve
merged 12 commits into
zephyrproject-rtos:master
from
wag-thom:fix_macro_empty_name_collision
Feb 7, 2025
Merged
sam0: dac: Rename EMPTY bit-fields to avoid name collision. #46
nandojve
merged 12 commits into
zephyrproject-rtos:master
from
wag-thom:fix_macro_empty_name_collision
Feb 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @nandojve I renamed the bit-fields to (Will do the rest afterward) |
nandojve
requested changes
Feb 7, 2025
586cdd6
to
c1c3819
Compare
nandojve
requested changes
Feb 7, 2025
EMPTY collides with Zephyr's utility macro. Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro. Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro. Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro. Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro. Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro. Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro. Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro. Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro. Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro. Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro. Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro. Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
c1c3819
to
df2bef5
Compare
nandojve
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename EMPTY bit-fields, since they collide with Zephyr's utility macro EMPTY.