Skip to content

sam0: dac: Rename EMPTY bit-fields to avoid name collision. #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wag-thom
Copy link

@wag-thom wag-thom commented Feb 7, 2025

Rename EMPTY bit-fields, since they collide with Zephyr's utility macro EMPTY.

@wag-thom
Copy link
Author

wag-thom commented Feb 7, 2025

Hi @nandojve

I renamed the bit-fields to EMPTYDB since they are all Data Buffer Empty Interrupt.
What do you think?

(Will do the rest afterward)

@nandojve nandojve self-assigned this Feb 7, 2025
Thomas Schranz added 12 commits February 7, 2025 12:19
EMPTY collides with Zephyr's utility macro.

Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro.

Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro.

Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro.

Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro.

Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro.

Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro.

Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro.

Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro.

Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro.

Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro.

Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
EMPTY collides with Zephyr's utility macro.

Signed-off-by: Thomas Schranz <electronics@wandfluh.com>
@wag-thom wag-thom force-pushed the fix_macro_empty_name_collision branch from c1c3819 to df2bef5 Compare February 7, 2025 11:26
@wag-thom wag-thom marked this pull request as ready for review February 7, 2025 11:29
@wag-thom wag-thom requested a review from nandojve February 7, 2025 13:08
@nandojve nandojve merged commit da76744 into zephyrproject-rtos:master Feb 7, 2025
6 checks passed
@wag-thom wag-thom deleted the fix_macro_empty_name_collision branch February 7, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants