Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esp32s3: psram: add sources to suport code relocation #423

Merged
merged 1 commit into from
Apr 7, 2025
Merged

esp32s3: psram: add sources to suport code relocation #423

merged 1 commit into from
Apr 7, 2025

Conversation

marekmatej
Copy link
Collaborator

Allow to use PSRAM code relocation on ESP32-S3.

@marekmatej marekmatej force-pushed the feature/psram_code_run branch from c754c38 to 2fa826f Compare April 2, 2025 21:46
@marekmatej marekmatej marked this pull request as ready for review April 2, 2025 21:47
@github-actions github-actions bot mentioned this pull request Apr 2, 2025
Open
@marekmatej marekmatej force-pushed the feature/psram_code_run branch from 2fa826f to 8e807fc Compare April 2, 2025 22:27
@marekmatej marekmatej force-pushed the feature/psram_code_run branch from 8e807fc to ed291db Compare April 2, 2025 23:17
@FacepalmMute
Copy link

While testing, I encountered the following error with CONFIG_ESP_BT_HEAP_SPIRAM enabled:
BLE assert rwble.c 505, param 00400010 00000000

Hope this rings a bell. If not, feel free to disregard this remark.

@marekmatej marekmatej force-pushed the feature/psram_code_run branch from ed291db to 7235821 Compare April 3, 2025 13:26
@marekmatej
Copy link
Collaborator Author

marekmatej commented Apr 3, 2025 •
edited
Loading

While testing, I encountered the following error with CONFIG_ESP_BT_HEAP_SPIRAM enabled: BLE assert rwble.c 505, param 00400010 00000000

Hope this rings a bell. If not, feel free to disregard this remark.

Can you please disable all flash writes and try again? I can reproduce the issue, but only by using central role.

@sylvioalves sylvioalves self-requested a review April 4, 2025 02:36
@marekmatej marekmatej force-pushed the feature/psram_code_run branch from 7235821 to ecad9f3 Compare April 7, 2025 16:27
@marekmatej
Copy link
Collaborator Author

While testing, I encountered the following error with CONFIG_ESP_BT_HEAP_SPIRAM enabled: BLE assert rwble.c 505, param 00400010 00000000
Hope this rings a bell. If not, feel free to disregard this remark.

Can you please disable all flash writes and try again? I can reproduce the issue, but only by using central role.

Since this issue can't be resolved rn I'm removing the BLE PSRAM support for now.

@wmrsouza wmrsouza self-requested a review April 7, 2025 17:25
zephyr, components: esp32s3: SPIRAM update
45b8b54 
* add missing sources
* support Wi-Fi SPIRAM heap
* Fix locking of SPI1 to work in start-up conditions.
* Update verbose message.

Signed-off-by: Marek Matej <marek.matej@espressif.com>
@marekmatej marekmatej force-pushed the feature/psram_code_run branch from ecad9f3 to 45b8b54 Compare April 7, 2025 17:34
@marekmatej marekmatej merged commit 1f61730 into zephyrproject-rtos:zephyr Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmrsouza wmrsouza wmrsouza approved these changes

@raffarost raffarost raffarost approved these changes

@LucasTambor LucasTambor Awaiting requested review from LucasTambor LucasTambor is a code owner

@sylvioalves sylvioalves Awaiting requested review from sylvioalves sylvioalves is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marekmatej @FacepalmMute @sylvioalves @wmrsouza @raffarost