Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wiseconnect: Fixed setting of si91x bus events in the driver path #94

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

ragurram26
Copy link
Contributor

Corrected the assignments of SL_SI91X_SOCKET_DATA_TX_PENDING_EVENT,
SL_SI91X_SOCKET_COMMAND_TX_PENDING_EVENT, and
SL_SI91X_TA_BUFFER_FULL_CLEAR_EVENT to si91x_bus_event instead of
si91x_event, ensuring proper setting for the bus events.

@jerome-pouiller
Copy link
Collaborator

jerome-pouiller commented Mar 26, 2025

Can you relocate the description of your PR in the commit log (the commit log is saved in git, PR descriptions are lost)

Let's try to be consistent. Wiseconnect tends to use si91x to name the WiFi block. So, replace si91 by si91x in your commit title.

Your Signed-off-by: is missing.

I think it's time to adopt the Upstream-status: convention. If you expect this patch will be applied in the upstream, add Upstream-status: pending, otherwise add Upstream-status: inappropriate (explanation).

This PR won't be merged until you send a PR to the Zephyr maintree upgrading the pointer to hal_silabs.

@ragurram26 ragurram26 changed the title wiseconnect: Fixed setting of si91 bus events in the driver path wiseconnect: Fixed setting of si91x bus events in the driver path Mar 26, 2025
@ragurram26
Copy link
Contributor Author

I have updated the description and title, added the signed-off, and updated the hal_silabs pointer in the west.yml file in the upstream Zephyr repo PR : zephyrproject-rtos/zephyr#87673

@jhedberg
Copy link
Member

Regarding the trailers, I believe they need to be in the last paragraph, i.e. no empty line before the signed-off-by line. At least my commit message editor highlights them a special way then, but not if the trailer is not part of the last paragraph (it's not considered a trailer then)

Corrected the assignments of SL_SI91X_SOCKET_DATA_TX_PENDING_EVENT,
SL_SI91X_SOCKET_COMMAND_TX_PENDING_EVENT, and
SL_SI91X_TA_BUFFER_FULL_CLEAR_EVENT to si91x_bus_event instead of
si91x_event, ensuring proper setting for the bus events.

Upstream-status: Inappropriate [Zephyr specific workaround for osEventFlags]
Signed-off-by: Rahul Gurram <rahul.gurram@silabs.com>
@jhedberg jhedberg merged commit cb17629 into zephyrproject-rtos:main Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants