simplicity_sdk: Import EFM32 PG23/PG23 platform files #95
Conversation
janchri
requested review from
jhedberg,
asmellby,
jerome-pouiller and
Martinhoff-maker
as code owners
There was a problem hiding this comment.
Great! Thanks for this contribution. There are a few things that will need to be changed for this to be merged:
- The commit that adds the files from Simplicity SDK must have a section describing the origin of the content in the commit body, see https://docs.zephyrproject.org/latest/contribute/guidelines.html#identifying-contribution-origin for guidelines and ab08d35 for an example.
- The commit that adds the files from Simplicity SDK should be a separate commit from the one that changes the scripts.
- The commit that patches the SecureFault_IRQn must start with "simplicity_sdk: Patch [...]" to work with an upcoming script that automates the application of Simplicity SDK updates (revert patches/update/reapply patches).
- See additional comments on the contents of the scripts themselves.
In general, pg23 should be considered an instance of xg23, and pg28 should be considered an instance of xg28. Please take inspiration from the introduction of xg29 in the main tree when you do corresponding changes there. We are in the process of changing the directory layout of dts/arm/silabs/ and soc/silabs/silabs_s2/ to better group related content together. This means that moving the existing efr32xg23.dtsi into the xg23 directory and renaming it to xg23.dtsi would be appreciated as part of adding support for pg23, since that file can then be reused for both.
janchri
force-pushed
the
main
branch
3 times, most recently
from
43ab7b5 to
dba5535
Compare
janchri
force-pushed
the
main
branch
3 times, most recently
from
6a2bd24 to
7697eea
Compare
Origin: Simplicity SDK License: Zlib URL: https://github.com/SiliconLabs/simplicity_sdk Commit: 8627f8482564dc6d94b56512740a39d6f409a0eb Version: 2024.12.0 Purpose: Import EFM32PG23/PG28 and EFR32FG28 device files to unlock BRD2504a and BRD2506a DevKits Signed-off-by: Christoph Jans <jans.christoph@gmail.com>
Adding xg28 to devices to generate xg28-clock.h. Import pg23 and pg28/fg28 platform files. Signed-off-by: Christoph Jans <jans.christoph@gmail.com>
janchri
force-pushed
the
main
branch
2 times, most recently
from
0dedee0 to
a0796eb
Compare
|
Hopefully now all request are incorporated in the changes. Will start preparing a board file PR on the primary github zephyr repo with your information on the xg23 as a common ancestor dtsi file. |
Add SecureFault_IRQn enum member if ARM_SECURE_FIRMWARE is set. Signed-off-by: Christoph Jans <jans.christoph@gmail.com>
Import EFM32 platform files in preparation for upstream support of two EFM32 devKits, namely BRD2504a and BRD2506a. Adding two new groups pg23/pg28 for non-radio developer boards.