Bluetooth: Audio: Shell: Replace ctx_shell with logging #69739
Closed
+1,098
−1,288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace uses of ctx_shell with logging. The ctx_shell is mostly (always?) used in callbacks, where spending time to print directly may affect the behavior of the stack, and should be avoided. Logging has other advantages, such as following the order of operations when also logging things from the stack. Some features like the verbose logging of advertising data have been slightly reworked to better work with the logging system. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Thalley
force-pushed
the
bt_audio_shell_logging
branch
from
00bdee5 to
4ab3b9e
Compare
Replace uses of ctx_shell with logging. The ctx_shell is mostly (always?) used in callbacks, where spending time to print directly may affect the behavior of the stack, and should be avoided. It also replaces uses of printk. Logging has other advantages, such as following the order of operations when also logging things from the stack. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
The ctx_shell have been replaced by (proper) logging instead, and can now safely be removed. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Thalley
force-pushed
the
bt_audio_shell_logging
branch
from
4ab3b9e to
673d06d
Compare
|
Closing this PR as this needs a better solution. Enhancement issue: #70945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace uses of ctx_shell with logging.
The ctx_shell is mostly (always?) used in callbacks,
where spending time to print directly may affect the behavior
of the stack, and should be avoided.
Logging has other advantages, such as following the order
of operations when also logging things from the stack.