devicetree: make DT_..._REG_ADDR return unsigned #78766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiobaltieri
force-pushed
the
dt-addr-unsigned
branch
from
1242e55 to
52ba330
Compare
bjarki-andreasen
previously approved these changes
Sep 20, 2024
fabiobaltieri
force-pushed
the
dt-addr-unsigned
branch
8 times, most recently
from
1658d64 to
542ebde
Compare
fabiobaltieri
changed the title
zephyrbot
added
area: Devicetree
area: W1
zephyrbot
requested review from
anangl,
casparfriedrich,
de-nordic,
decsny,
galak,
str4t0m,
swift-tk,
tbursztyka and
teburd
fabiobaltieri
dismissed stale reviews from swift-tk, bjarki-andreasen, and teburd
via
884ac72
fabiobaltieri
force-pushed
the
dt-addr-unsigned
branch
from
a8b98dc to
884ac72
Compare
fabiobaltieri
removed
the
Architecture Review
|
decsny
reviewed
Oct 1, 2024
fabiobaltieri
force-pushed
the
dt-addr-unsigned
branch
from
884ac72 to
ebe92e3
Compare
ghost
previously approved these changes
Oct 1, 2024
henrikbrixandersen
previously approved these changes
Oct 1, 2024
decsny
previously approved these changes
Oct 1, 2024
teburd
previously approved these changes
Oct 1, 2024
bjarki-andreasen
previously approved these changes
Oct 1, 2024
|
@fabiobaltieri rebase needed |
`DT_..._REG_ADDR` macros do not always return an unsigned value. This commit adds and unsigned 32bit prefix to ensure the value is always unsigned. Signed-off-by: Jeppe Odgaard <jeppe.odgaard@prevas.dk> Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
fabiobaltieri
dismissed stale reviews from bjarki-andreasen, teburd, decsny, henrikbrixandersen, and ghost
via
cc04d7f
fabiobaltieri
force-pushed
the
dt-addr-unsigned
branch
from
ebe92e3 to
cc04d7f
Compare
|
Merge conflict, rebased, I dropped the flash_simulator commit entirely as the validation code has been changed and I think the casting is not needed anymore, hang on for the CI run (can't recall what platform/combo test was failing specifically) will reapply if it's still a problem. |
bjarki-andreasen
approved these changes
Oct 2, 2024
|
hurray! |
gmarull
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DT_..._REG_ADDRmacros do not always return an unsigned value. This commit adds and unsigned 32bit prefix to ensure the value is always unsigned.More context:
Picking up from #70761