Add mcxa156 i3c support #83012
Add mcxa156 i3c support #83012
Conversation
zephyrbot
added
platform: NXP
zephyrbot
requested review from
avisconti,
butok,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
jeppenodgaard,
kartben,
MaureenHelm,
mmahadevan108,
teburd,
tristan-google,
ubieda,
yperess and
yvanderv
NeilChen93
force-pushed
the
add_mcxa156_i3c_support
branch
from
8dfa3c8 to
4fd84e1
Compare
| @@ -10,6 +10,7 @@ tests: | |||
| - robokit1 # ntc_thermistor | |||
| - adi_eval_adin1110ebz # adt7420 | |||
| - frdm_mcxn947/mcxn947/cpu0 # p3t1755 | |||
| - frdm_mcxa156 # p3t1755 | |||
There was a problem hiding this comment.
Drop. There is no need to add to CI load as this will not be testing anything that isn't already tested elsewhere (i3c driver tests, sensor driver test, or even the line just above--even if it should likely also go away)
https://docs.zephyrproject.org/latest/samples/sample_definition_and_criteria.html#twister-should-be-able-to-build-every-sample
There was a problem hiding this comment.
This shouldn't be defined in an overlay if it's an on-board sensor. Move to board dts
There was a problem hiding this comment.
Thanks reminder, Updated.
There was a problem hiding this comment.
Hi @kartben , after move this to board dts, CI compilation report error, samples/sensor/thermometer build fail. This example also use aliases ambient-temp0, but frdm_mcxa156 don't support it. So cancel this update.
There was a problem hiding this comment.
I don't quite understand. It sounds like that might have been a legitimate build failure. Can you post a link to the CI run or paste the console output from a failed build?
There was a problem hiding this comment.
Looked over this PR and I agree this should be moved to the board. The rest of the patches look good to me.
NeilChen93
force-pushed
the
add_mcxa156_i3c_support
branch
from
4fd84e1 to
45d23c9
Compare
NeilChen93
force-pushed
the
add_mcxa156_i3c_support
branch
from
45d23c9 to
bf858a7
Compare
NeilChen93
force-pushed
the
add_mcxa156_i3c_support
branch
2 times, most recently
from
8a1c0c2 to
97c0d1e
Compare
NeilChen93
force-pushed
the
add_mcxa156_i3c_support
branch
from
97c0d1e to
ff9c502
Compare
Add mcxa156 i3c clock support Signed-off-by: Neil Chen <cheng.chen_1@nxp.com>
Add i3c nodes to NXP MCXA156 dtsi file Signed-off-by: Neil Chen <cheng.chen_1@nxp.com>
Support i3c for NXP frdm_mcxa156 board. Test it using samples/sensor/thermometer. Signed-off-by: Neil Chen <cheng.chen_1@nxp.com>
NeilChen93
force-pushed
the
add_mcxa156_i3c_support
branch
from
ff9c502 to
b304c89
Compare
Add config TEST_RANDOM_GENERATOR to support function sys_rand_get Signed-off-by: Neil Chen <cheng.chen_1@nxp.com>
| @@ -10,3 +10,4 @@ CONFIG_SERIAL=y | |||
| CONFIG_UART_INTERRUPT_DRIVEN=y | |||
| CONFIG_GPIO=y | |||
| CONFIG_LPADC_DO_OFFSET_CALIBRATION=y | |||
| CONFIG_TEST_RANDOM_GENERATOR=y | |||
There was a problem hiding this comment.
This should not be enabled for real hardware by default. How come this was added?
Add mcxa156 i3c support