drivers: video: emul: simplify, avoid mission creep #83220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicpoulain
reviewed
Jan 30, 2025
| @@ -157,7 +157,7 @@ ZTEST(video_common, test_video_vbuf) | |||
| zexpect_ok(video_set_format(rx_dev, VIDEO_EP_OUT, &fmt)); | |||
|
|
|||
| /* Allocate a buffer, assuming prj.conf gives enough memory for it */ | |||
| vbuf = video_buffer_alloc(fmt.pitch * fmt.height, K_FOREVER); | |||
| vbuf = video_buffer_alloc(fmt.pitch * fmt.height, K_NO_WAIT); | |||
There was a problem hiding this comment.
This change is not explained in the commit message. Also I suppose the below assertion is then not valid anymore?
There was a problem hiding this comment.
Good point thank you, I will revisit it.
There was a problem hiding this comment.
This is now its own commit proposing not to wait CI timeout when running out of video memory.
josuah
force-pushed
the
pr-video-emul-fewer-ram
branch
2 times, most recently
from
da560ab to
31d459b
Compare
josuah
changed the title
josuah
force-pushed
the
pr-video-emul-fewer-ram
branch
2 times, most recently
from
1890b61 to
f26add3
Compare
Only store a single line of the full frame. This allows to support a large enough frame size to remove the Kconfig option, which simplifies the implementation (fewer checks needed). Signed-off-by: Josuah Demangeon <me@josuah.net>
Depending on the log mode selected, the device name will be visible for every log message, so not useful to add it again in the log payload. Various other log improvements also added. Signed-off-by: Josuah Demangeon <me@josuah.net>
Deduplicate the registers of "modes": only a single definition of each: pixelformats, resolutions, framerate. Signed-off-by: Josuah Demangeon <me@josuah.net>
Remove the test pattern generator implemented inline in video_emul_imager, as this feature is overlapping with VIDEO_SW_GENERATOR, and does not add value to the driver. Signed-off-by: Josuah Demangeon <me@josuah.net>
Fail immediately during tests rather than letting K_FOREVER trigger a CI timeout. Signed-off-by: Josuah Demangeon <me@josuah.net>
josuah
force-pushed
the
pr-video-emul-fewer-ram
branch
from
f26add3 to
cf9ae77
Compare
Use a video control ID in the private range rather than using an existing CID, as the emulated imager does not effectively applies these properties to the image feed and are just for API test purpose. Signed-off-by: Josuah Demangeon <me@josuah.net>
loicpoulain
approved these changes
Mar 19, 2025
ngphibang
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general goal is making
video_emul_*just enough complexity to test the APIs on CI.VIDEO_SW_GENERATORdoes it and no use in maintaining it twice.[EDIT: updated the PR goals mid-way]