drivers: entropy: add maxq10xx

[maass-hamburg]

add maxq10xx entropy device.

[m-byte]

This looks weird to me. IMHO, the MAXQ10xx is a multi function device, not just a random number generator. Therefore, it should be implemented as such.

[ozersa]

This looks weird to me. IMHO, the MAXQ10xx is a multi function device, not just a random number generator. Therefore, it should be implemented as such.

Agreed, maxq10xx family is secure authenticator that supports multiple function, the implementation of them shall not be restrict it for TRNG. I think there might be a new driver class folder like: "drivers/auth" for authenticator OR existing crypto driver interface be extended then used as crypto device.

[maass-hamburg]

@ozersa I already changed it to mfd. so that the crypto or auth driver can be added later

[maass-hamburg]

ping @ceolin @ozersa

[ceolin]

It looks ok to me.

[maass-hamburg]

ping @ozersa

[ozersa]

Thanks for enabling maxq10xx on zephyr.
Sorry for late response.

[kartben]

Suggested change

	#ifndef ZEPHYR_INCLUDE_DRIVERS_MFD_MAXQ1XX_H_
	#define ZEPHYR_INCLUDE_DRIVERS_MFD_MAXQ1XX_H_
	#include <zephyr/device.h>
	#include <zephyr/kernel.h>
	#ifdef __cplusplus
	extern "C" {
	#endif
	/**
	* @brief Get the semaphore reference for a MAXQ1xx instance. Callers
	* should pass the return value to k_sem_take/k_sem_give
	*
	* @param[in] dev Pointer to device struct of the driver instance
	*
	* @return Address of the semaphore
	*/
	struct k_sem *mfd_maxq10xx_get_lock(const struct device *dev);
	#ifdef __cplusplus
	}
	#endif
	#endif /* ZEPHYR_INCLUDE_DRIVERS_MFD_MAXQ1XX_H_ */
	#ifndef ZEPHYR_INCLUDE_DRIVERS_MFD_MAXQ10XX_H_
	#define ZEPHYR_INCLUDE_DRIVERS_MFD_MAXQ10XX_H_
	#include <zephyr/device.h>
	#include <zephyr/kernel.h>
	#ifdef __cplusplus
	extern "C" {
	#endif
	/**
	* @brief Get the semaphore reference for a MAXQ1xx instance. Callers
	* should pass the return value to k_sem_take/k_sem_give
	*
	* @param[in] dev Pointer to device struct of the driver instance
	*
	* @return Address of the semaphore
	*/
	struct k_sem *mfd_maxq10xx_get_lock(const struct device *dev);
	#ifdef __cplusplus
	}
	#endif
	#endif /* ZEPHYR_INCLUDE_DRIVERS_MFD_MAXQ10XX_H_ */

[tomi-font]

Overall nice! Just some minor remarks.

[maass-hamburg]

@ceolin please re-approve as the maintainer