Re-enable -Wsometimes-uninitialized for clang
#83922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thughes
changed the title
-Wsometimes-uninitialized for clang
thughes
force-pushed
the
fix-sometimes-uninitialized
branch
2 times, most recently
from
c1b26fa to
14bea22
Compare
zephyrbot
requested review from
57300,
aasinclair,
Casper-Bonde-Bose,
galak,
gmarull,
jeremybettis,
jhedberg,
MariuszSkamra,
nashif,
nordicjm,
sjanc,
stephanosio,
tejlmand,
Thalley and
XenuIsWatching
Thalley
requested changes
Jan 23, 2025
thughes
force-pushed
the
fix-sometimes-uninitialized
branch
from
14bea22 to
e70b196
Compare
Thalley
previously approved these changes
Jan 24, 2025
jhedberg
previously approved these changes
Jan 24, 2025
nordicjm
previously approved these changes
Jan 28, 2025
|
@stephanosio Looks like I need your approval. Thanks! |
|
@tejlmand I'm not sure about the exact process, but it looks like you'd be considered a MAINTAINER for this change. Is it possible to make yourself the assignee or do I need to wait for @stephanosio? |
thughes
force-pushed
the
fix-sometimes-uninitialized
branch
from
e70b196 to
418188a
Compare
tejlmand
previously approved these changes
Feb 6, 2025
zephyrbot
added
area: Bluetooth
area: Build System
area: Bluetooth ISO
thughes
force-pushed
the
fix-sometimes-uninitialized
branch
from
034413b to
d5ab040
Compare
thughes
force-pushed
the
fix-sometimes-uninitialized
branch
3 times, most recently
from
b402ed6 to
9e53498
Compare
thughes
force-pushed
the
fix-sometimes-uninitialized
branch
from
9e53498 to
9c1362a
Compare
thughes
force-pushed
the
fix-sometimes-uninitialized
branch
from
9c1362a to
ca39e61
Compare
tejlmand
approved these changes
Mar 14, 2025
thughes
force-pushed
the
fix-sometimes-uninitialized
branch
from
ca39e61 to
00b1a60
Compare
Building libraries.cmsis_dsp.distance with clang warns:
tests/lib/cmsis_dsp/distance/src/f32.c:99:3: error: variable 'val' is
used uninitialized whenever switch default is taken
[-Werror,-Wsometimes-uninitialized]
default:
^~~~~~~
tests/lib/cmsis_dsp/distance/src/f32.c:104:19: note: uninitialized use
occurs here
output[index] = val;
^~~
tests/lib/cmsis_dsp/distance/src/f32.c:57:16: note: initialize the
variable 'val' to silence this warning
float32_t val;
^
= 0.0
Not really necessary since there is a zassert_unreachable, but doesn't
hurt to initialize the variable.
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
thughes
force-pushed
the
fix-sometimes-uninitialized
branch
2 times, most recently
from
a3801ef to
7b498d0
Compare
All warnings in the code base have been resolved. Signed-off-by: Tom Hughes <tomhughes@chromium.org>
thughes
force-pushed
the
fix-sometimes-uninitialized
branch
from
7b498d0 to
17760aa
Compare
kartben
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All warnings in the code base have been resolved.