Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: lilygo: ttgo_tbeam: initial support #83943

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

boards: lilygo: ttgo_tbeam: initial support #83943

wants to merge 1 commit into from

Conversation

lfelten
Copy link
Contributor

@lfelten lfelten commented Jan 14, 2025 •
edited
Loading

adds initial support for Lilygo TTGO TBeam board

Depends on #82474 to be merged

@lfelten lfelten marked this pull request as draft January 14, 2025 09:06
@lfelten lfelten force-pushed the lilygo_ttgo_tbeam branch 3 times, most recently from dce5c91 to b41f66e Compare March 15, 2025 09:43
@lfelten
Copy link
Contributor Author

lfelten commented Mar 15, 2025

Depends on PR 87139
#87139

@lfelten lfelten force-pushed the lilygo_ttgo_tbeam branch from b41f66e to a467f51 Compare March 19, 2025 16:10
@lfelten lfelten force-pushed the lilygo_ttgo_tbeam branch from a467f51 to ebde378 Compare March 27, 2025 05:35
@lfelten lfelten marked this pull request as ready for review March 27, 2025 08:59
@lfelten
boards: lilygo: ttgo_tbeam: initial support
323fece 
adds initial support for Lilygo TTGO TBeam board

Co-authored-by: Jamie <40387179+nordicjm@users.noreply.github.com>
Co-authored-by: Benjamin Cabé <benjamin@zephyrproject.org>

Signed-off-by: Lothar Felten <lothar.felten@gmail.com>
@lfelten lfelten force-pushed the lilygo_ttgo_tbeam branch from ebde378 to 323fece Compare April 3, 2025 06:54
@lfelten
Copy link
Contributor Author

lfelten commented Apr 3, 2025

@aasinclair @gmarull @danieldegrasse @kartben
Just rebased to the current main.
Should I rebase to main and push periodically?

@kartben
Copy link
Collaborator

kartben commented Apr 3, 2025

@aasinclair @gmarull @danieldegrasse @kartben Just rebased to the current main. Should I rebase to main and push periodically?

no need as long as CI passes -- however, can you look at addressing @nordicjm's comments when you have a chance?

@lfelten
Copy link
Contributor Author

lfelten commented Apr 3, 2025

@aasinclair @gmarull @danieldegrasse @kartben
Just rebased to the current main.
Should I rebase to main and push periodically?

@aasinclair @gmarull @danieldegrasse @kartben Just rebased to the current main. Should I rebase to main and push periodically?

no need as long as CI passes -- however, can you look at addressing @nordicjm's comments when you have a chance?

Hi @kartben I fixed the ttgo_tbeam-pinctrl.dtsi (whitespace), ttgo_tbeam_esp32_procpu.dts (whitespace) and ttgo_tbeam_esp32_procpu_defconfig (remove CONFIG_MAIN_STACK_SIZE) a while ago.
Comparing ttgo_tbeam* to ttgo_lora32* I might now have to fix ttgo_lora32-pinctrl.dtsi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nordicjm nordicjm nordicjm left review comments

@aasinclair aasinclair Awaiting requested review from aasinclair

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@gmarull gmarull Awaiting requested review from gmarull

At least 2 approving reviews are required to merge this pull request.

Assignees

@gmarull gmarull

Labels
area: Boards area: MFD area: Regulators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lfelten @kartben @gmarull @nordicjm @zephyrbot