Replace diagnostic pragmas with TOOLCHAIN_* macros
#84065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thughes
force-pushed
the
replace-diagnostic-macros-with-toolchain-disable
branch
2 times, most recently
from
226f7d9 to
55820c5
Compare
thughes
changed the title
TOOLCHAIN_* macros
thughes
force-pushed
the
replace-diagnostic-macros-with-toolchain-disable
branch
from
55820c5 to
5e07390
Compare
thughes
force-pushed
the
replace-diagnostic-macros-with-toolchain-disable
branch
4 times, most recently
from
ac4636e to
67c4390
Compare
zephyrbot
requested review from
bbolen,
carlocaione,
ceolin,
cfriedt,
dcpleung,
galak,
MaureenHelm,
microbuilder,
mrkhldn,
nashif,
nordic-krch,
stephanosio,
tejlmand,
wearyzen and
ycsin
|
signal.h looks fine. I suspect @nordic-krch should also review |
thughes
force-pushed
the
replace-diagnostic-macros-with-toolchain-disable
branch
2 times, most recently
from
a143260 to
d0fa2c4
Compare
thughes
force-pushed
the
replace-diagnostic-macros-with-toolchain-disable
branch
4 times, most recently
from
897df83 to
baae26c
Compare
thughes
force-pushed
the
replace-diagnostic-macros-with-toolchain-disable
branch
from
baae26c to
9c7cca2
Compare
The TOOLCHAIN_IGNORE_WSHADOW_BEGIN and TOOLCHAIN_IGNORE_WSHADOW_END macros can be replaced with the more generic TOOLCHAIN_DISABLE_WARNING(TOOLCHAIN_WARNING_SHADOW) and TOOLCHAIN_ENABLE_WARNING(TOOLCHAIN_WARNING_SHADOW) macros. Signed-off-by: Tom Hughes <tomhughes@chromium.org>
The TOOLCHAIN_DISABLE_WARNING/TOOLCHAIN_ENABLE_WARNING macros are easier to read and compiler agnostic. Signed-off-by: Tom Hughes <tomhughes@chromium.org>
thughes
force-pushed
the
replace-diagnostic-macros-with-toolchain-disable
branch
from
9c7cca2 to
9da9bf1
Compare
Many warnings were disabled for all compilers, even though they are gcc-specific warnings. Now that clang has -Wunknown-warning-option enabled, this can cause compilation failures when building with clang toolchains. Use TOOLCHAIN_DISABLE_GCC_WARNING for all gcc-specific macros. https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html https://clang.llvm.org/docs/DiagnosticsReference.html Fixes: zephyrproject-rtos#84138 Signed-off-by: Tom Hughes <tomhughes@chromium.org>
thughes
force-pushed
the
replace-diagnostic-macros-with-toolchain-disable
branch
from
9da9bf1 to
8085f9a
Compare
|
@tejlmand This one is ready now that all dependencies have been merged. |
tejlmand
approved these changes
Mar 19, 2025
|
I need another approver for this to be merged. @dcpleung @cfriedt @nordic-krch Would any of you be able to take a look? Thanks! |
cfriedt
approved these changes
Mar 20, 2025
thughes
added a commit
to thughes/zephyr
that referenced
this pull request
Mar 21, 2025
These macros were recently introduced and replaced everywhere (zephyrproject-rtos#84065), but this was missed. Signed-off-by: Tom Hughes <tomhughes@chromium.org>
thughes
added a commit
to thughes/zephyr
that referenced
this pull request
Mar 21, 2025
These macros were recently introduced and replaced everywhere (zephyrproject-rtos#84065), but this was missed. Signed-off-by: Tom Hughes <tomhughes@chromium.org>
thughes
added a commit
to thughes/zephyr
that referenced
this pull request
Mar 21, 2025
…ning zephyrproject-rtos#84065 replaced diagnostic pragmas with TOOLCHAIN_* macros, but we don't need to use that here since __used is a cleaner way to indicate that the function is used and will also prevent it from being optimized away at link time if LTO is enabled. Signed-off-by: Tom Hughes <tomhughes@chromium.org>
thughes
added a commit
to thughes/zephyr
that referenced
this pull request
Mar 21, 2025
…ning zephyrproject-rtos#84065 replaced diagnostic pragmas with TOOLCHAIN_* macros, but we don't need to use that here since __used is a cleaner way to indicate that the function is used and will also prevent it from being optimized away at link time if LTO is enabled. Signed-off-by: Tom Hughes <tomhughes@chromium.org>
kartben
pushed a commit
that referenced
this pull request
Mar 26, 2025
These macros were recently introduced and replaced everywhere (#84065), but this was missed. Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TOOLCHAIN_DISABLE_WARNING/TOOLCHAIN_ENABLE_WARNINGmacros are easier to read and compiler agnostic.Depends on #84063
Fixes #84138