drivers: sensor: mpu6050: adds samplerate divider setting #84452
+55
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
asemjonovs,
avisconti,
jeppenodgaard,
kartben,
MaureenHelm,
nashif,
teburd,
tristan-google,
ubieda and
yperess
MaureenHelm
requested changes
Jan 23, 2025
TilmannUnte
force-pushed
the
mpu6050_smplrt_div
branch
from
4ac7c74 to
01e6004
Compare
|
Sorry for the long wait, work got in the way. I did my best to move the sensor specific settings from Kconfig to Devicetree. However, there is one thing I'm still somewhat unhappy with and I'm hoping for suggestions: |
TilmannUnte
force-pushed
the
mpu6050_smplrt_div
branch
from
01e6004 to
666e8eb
Compare
TilmannUnte
force-pushed
the
mpu6050_smplrt_div
branch
from
666e8eb to
033e0c0
Compare
yperess
requested changes
Mar 20, 2025
Moves the MPU6050 accel/gyro scale settings from KConfig to Devicetree. Adds a new setting for the MPU6050 sample rate divider register and transmits it to the sensor upon initialization. This helps to reduce the interrupt firing rate when combined with the data ready trigger. A default division factor is provided which ensures compatibility with existing applications. The MPU6050 sample application is extended and used for hardware tests. Signed-off-by: Tilmann Unte <unte@es-augsburg.de>
TilmannUnte
force-pushed
the
mpu6050_smplrt_div
branch
from
033e0c0 to
5b7b3d1
Compare
yperess
approved these changes
Mar 20, 2025
MaureenHelm
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the MPU6050 accel/gyro scale settings from KConfig to Devicetree.
Adds a new setting for the MPU6050 sample rate divider register and
transmits it to the sensor upon initialization.
This helps to reduce the interrupt firing rate when combined with the
data ready trigger.
A default division factor is provided which ensures compatibility with
existing applications.
The MPU6050 sample application is extended and used for hardware tests.