drivers: ethernet: dm8806: allow multiple speed advertisement #84639
+39
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User request for 100B full duplex can't reduce the ability to negotiate only this one speed; 100B half duplex can't reduce the ability to negotiate only this one speed and so on. It is only the advertisement speed, therefore other speeds like 100B half duplex and 10B half duplex are also allowed if autonegotiation process is activeated. This change has been introduced due to problems with autonegotation with some endpoints. It turned out, that only one advertise speed prevent correct autonegotiation process. Problem isn't occurs on all ethernet devices/endpoints. Signed-off-by: Robert Slawinski <robert.slawinski.ext@indurad.com>
robi251
force-pushed
the
multiple_speed_mode
branch
from
0f4f3dc to
51b0a64
Compare
maass-hamburg
approved these changes
Mar 5, 2025
maass-hamburg
changed the title
decsny
requested changes
Mar 5, 2025
| if (ret) { | ||
| LOG_ERR("Failed to write data to DM8806"); | ||
| LOG_ERR("Failes to read data drom DM8806"); |
There was a problem hiding this comment.
im not sure what happened here but these are not words
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User request for 100B full duplex can't reduce the ability to negotiate only this one speed; 100B half duplex can't reduce the ability to negotiate only this one speed and so on. It is only the advertisement speed, therefore other speeds like 100B half duplex and 10B half duplex are also allowed if auto-negotiation process is activated.
This change has been introduced due to problems with auto-negotiation with some endpoints. It turned out, that only one advertise speed prevent correct auto-negotiation process. Problem isn't occurs on all Ethernet devices/endpoints.