samples: hid-keyboard: clear report buffer at startup #85066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary semicolons from macro definitions. The semicolon is added by the macro user. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
Set the report buffer to 0, since it can be placed in a memory area that is not initialized during boot, for example nocache area. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
| name[ROUND_UP(size, UDC_BUF_GRANULARITY)]; | ||
| name[ROUND_UP(size, UDC_BUF_GRANULARITY)] |
There was a problem hiding this comment.
Did you intend to include this commit here? Asking since it's not mentioned in the PR description.
There was a problem hiding this comment.
I fixed it for you.
tmon-nordic
reviewed
Feb 5, 2025
| * Set the report buffer to 0, since it can be placed in a memory area | ||
| * that is not initialized during boot. | ||
| */ | ||
| memset(report, 0, sizeof(report)); |
There was a problem hiding this comment.
report is defined with UDC_STATIC_BUF_DEFINE(report, KB_REPORT_COUNT); which essentially does translate static uint8_t array with attributes. @tejlmand is it really valid that placing a static array in __nocache section results in it not being initialized at startup?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include: udc: remove semicolon from macro definition
Set the report buffer to 0, since it can be placed in a memory area
that is not initialized during boot, for example nocache area.