[Backport v3.7-branch] arch: arm: cortex_m: Fix meta-IRQ unable to preempt from interrupt #85139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… preemptible" This reverts commit 42036cd. Architecture specific code should not do preemption checking before context switch. This is already handled by the scheduler, so duplicating it would be redundant and error prone. These checks used to be necessary, but the scheduler has been rewritten since then and the checks were removed in 3a0cb2d (kernel: Remove legacy preemption checking, 2018-05-23). The check this reverts was also incorrect, as it didn't take scheduler locking nor meta-IRQs into account. Fixes #80574 Signed-off-by: Kalle Kietäväinen <kalle.kietavainen@silabs.com> (cherry picked from commit d929b8a)
The intention of the test is to have a meta-IRQ preempt a cooperative thread, then ensure the same cooperative thread is resumed back to instead of a higher priority thread. Thus, the test needs to assert that the lower priority cooperative thread is not yet complete when it makes the higher priority thread ready to run. This change reveals bugs like #80574, where the meta-IRQ is unable to preempt a cooperative thread. Signed-off-by: Kalle Kietäväinen <kalle.kietavainen@silabs.com> (cherry picked from commit 52b8e3d)
zephyrbot
added
Backport
zephyrbot
requested review from
andyross,
bbolen,
carlocaione,
ceolin,
cfriedt,
dcpleung,
galak,
ithinuel,
MaureenHelm,
microbuilder,
nashif,
npitre,
peter-mitsis,
stephanosio and
TaiJuWu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 52b8e3d~2..52b8e3d from #84509.
Fixes #80574