llext: Use relocatable by default for xtensa #85190
Conversation
tests/subsys/llext/testcase.yaml
Outdated
| extra_conf_files: ['no_mem_protection.conf'] | ||
| extra_configs: | ||
| - CONFIG_LLEXT_STORAGE_WRITABLE=y | ||
| - CONFIG_LLEXT_TYPE_ELF_SHAREDLIB=y |
There was a problem hiding this comment.
This new entry is now replacing the previous meaning of llext.writable on Xtensa, while llext.writable_relocatable now becomes identical to llext.writable there, same for SLID versions. Maybe we shouldn't rely on arch defaults and make explicit tests for each ELF type? E.g. llext.writable_relocatable, llext.writable_sharedlib and llext.writable_object?
There was a problem hiding this comment.
I'm frankly not even sure what the object elf type is here... there's no ET_OBJECT or ET_SHARED... its ET_REL or ET_DYN that we actually support here and realistically I need to correct this.
There was a problem hiding this comment.
I plan on fixing the object type options in the future. I don't want to break things right before a release.
There was a problem hiding this comment.
Sorry, I still don't think having llext.writable and llext.writable_relocatable perform the same testing on Xtensa (and potentially on other platforms) is a particularly good option. What should llext.writable now mean? Don't think leaving it just the default is very beneficial here since it can overlap with other tests
LLEXT supports relocatable ELFs with Xtensa alongside dynamic/shared ELFs. Not all Xtensa toolchains support working with/linking shared ELFs though. Change the default to be relocatable and only test shared with working toolchains. Signed-off-by: Tom Burdick <thomas.burdick@intel.com>
teburd
force-pushed
the
llext_xtensa_defaults
branch
from
010748a to
fd5031b
Compare
LLEXT supports relocatable ELFs with Xtensa alongside dynamic/shared ELFs. Not all Xtensa toolchains support working with/linking shared ELFs though. Change the default to be relocatable and only test shared with working toolchains.