sensors: add als-pt19 sensor support #85839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
asemjonovs,
avisconti,
jeppenodgaard,
kartben,
MaureenHelm,
nashif,
teburd,
tristan-google,
ubieda and
yperess
dipakgmx
changed the title
dipakgmx
force-pushed
the
feat/add-als-pt19-sensor
branch
from
3aff33c to
5b582ef
Compare
Could you change the commit message to:
because the only changes are in the binding file? |
yperess
requested changes
Feb 18, 2025
dipakgmx
force-pushed
the
feat/add-als-pt19-sensor
branch
from
5b582ef to
446f5ce
Compare
yasinustunerg
previously approved these changes
Feb 19, 2025
yperess
previously approved these changes
Feb 20, 2025
jilaypandya
previously approved these changes
Feb 20, 2025
dipakgmx
dismissed stale reviews from jilaypandya, yperess, and yasinustunerg
via
fb64438
Sure. I also think all the *_polling samples are generic. |
yperess
previously approved these changes
Feb 26, 2025
yasinustunerg
previously approved these changes
Feb 26, 2025
MaureenHelm
requested changes
Feb 27, 2025
| return 0; | ||
| } | ||
|
|
||
| static const struct sensor_driver_api als_pt19_driver_api = { |
There was a problem hiding this comment.
Suggested change
| static const struct sensor_driver_api als_pt19_driver_api = { | |
| static DEVICE_API(sensor, als_pt19_driver_api) = { |
| } | ||
|
|
||
| #define ALS_PT19_INST(inst) \ | ||
| static struct als_pt19_data als_pt19_data_##inst = {0}; \ |
There was a problem hiding this comment.
Suggested change
| static struct als_pt19_data als_pt19_data_##inst = {0}; \ | |
| static struct als_pt19_data als_pt19_data_##inst; \ |
dipakgmx
force-pushed
the
feat/add-als-pt19-sensor
branch
from
fb64438 to
d72a439
Compare
|
|
||
| compatible: "everlight,als-pt19" | ||
|
|
||
| include: seeed,grove-light.yaml |
There was a problem hiding this comment.
This should probably be sensor-device.yaml and then an io-channel property should be added in this file.
dipakgmx
force-pushed
the
feat/add-als-pt19-sensor
branch
2 times, most recently
from
b51352b to
f48df7a
Compare
MaureenHelm
previously approved these changes
Mar 25, 2025
jeppenodgaard
previously approved these changes
Mar 26, 2025
kartben
requested changes
Mar 26, 2025
| .. zephyr:code-sample:: grove_light | ||
| :name: Grove Light Sensor | ||
| .. zephyr:code-sample:: light_sensor_polling | ||
| :name: Generic Light Sensor Polling Sample |
There was a problem hiding this comment.
Suggested change
| :name: Generic Light Sensor Polling Sample | |
| :name: Generic Light Sensor Polling |
| @@ -16,23 +16,21 @@ Requirements | |||
| To use this sample, the following hardware is required: | |||
|
|
|||
| * A board with ADC support | |||
| * `Grove Light Sensor`_ | |||
| * `Grove Base Shield`_ | |||
| * A supported light sensor (e.g., `Grove Light Sensor`_) | |||
There was a problem hiding this comment.
Suggested change
| * A supported light sensor (e.g., `Grove Light Sensor`_) | |
| * A supported light sensor (e.g., `Grove Light Sensor`_), available as ``light-sensor`` Devicetree | |
| alias. |
| # Copyright (c) 2025 Dipak Shetty <shetty.dipak@gmx.com> | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| description: Everlight Ambient Light Sensor |
There was a problem hiding this comment.
Suggested change
| description: Everlight Ambient Light Sensor | |
| description: Everlight ALS-PT19 Ambient Light Sensor |
Added new binding for Everlight ALS-PT19 Ambient Light Sensor. Signed-off-by: Dipak Shetty <shetty.dipak@gmx.com>
Adds driver for Everlight ALS-PT19 Ambient Light Sensor. Signed-off-by: Dipak Shetty <shetty.dipak@gmx.com>
Moved the grove light sensor into a generic light sensor sample. Replaced board specific node name for light sensor with an alias. Refactored project name to reflect generic light sensor. Signed-off-by: Dipak Shetty <shetty.dipak@gmx.com>
Sample extended to support the everlight light sensor on the frdm_mcxw71 board. Signed-off-by: Dipak Shetty <shetty.dipak@gmx.com>
dipakgmx
dismissed stale reviews from jeppenodgaard and MaureenHelm
via
616a9a7
dipakgmx
force-pushed
the
feat/add-als-pt19-sensor
branch
from
f48df7a to
616a9a7
Compare
kartben
approved these changes
Mar 27, 2025
MaureenHelm
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ALS-PT19 ambient sensor support.
The following are done in the PR:
Added new binding for the sensor
Added new sensor driver
Added basic sample to measure ambient light readings using the sensor present on the frdm_mcxw71 board.
Signed-off-by: Dipak Shetty shetty.dipak@gmx.com