Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: Update hal_stm32 to add released binaries of stm32wb #85980

Merged

Conversation

benothmn-st
Copy link
Collaborator

Update hal_stm32 to add the history of the released binaries to be flashed in the Cortex-M0 coprocessor.

@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Feb 19, 2025
@zephyrbot
Copy link
Collaborator

zephyrbot commented Feb 19, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_stm32 zephyrproject-rtos/hal_stm32@04ccc77 zephyrproject-rtos/hal_stm32@5dcc08c zephyrproject-rtos/hal_stm32@04ccc779..5dcc08c1

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_stm32 DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Feb 19, 2025
@benothmn-st benothmn-st force-pushed the stm32wb_add_releases_list branch from d8d6160 to 9b8611f Compare February 19, 2025 16:23
@zephyrbot zephyrbot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Feb 19, 2025
@fabiobaltieri
Copy link
Member

@benothmn-st @erwango does this needs to go for 4.1? https://github.com/zephyrproject-rtos/hal_stm32/compare/55043bcc35fffa3b4a8c75a696d932b5020aad09..5dcc08c119d421fec7d67555fc7b0aa220288e56 shows quite some extra stuff, is the core change to be considered a fix?

@erwango
Copy link
Member

erwango commented Feb 19, 2025

@benothmn-st @erwango does this needs to go for 4.1? https://github.com/zephyrproject-rtos/hal_stm32/compare/55043bcc35fffa3b4a8c75a696d932b5020aad09..5dcc08c119d421fec7d67555fc7b0aa220288e56 shows quite some extra stuff, is the core change to be considered a fix?

Yeah, my bad. This was actually merged w/o manifest update before feature freeze and this shows up now.
This being said, the changes are only pure additions of N6 Ethernet pin configuration (Matching N6 Eth PR is not upstream yet), and config update on the pin generation script (which effects are reflected in the new generated pins).
So technically this is purely no risk, but I understand this could bother you.

@fabiobaltieri
Copy link
Member

@erwango your comment leaves me as confused as before :-) pick a milestone

@erwango erwango added this to the v4.1.0 milestone Feb 20, 2025
asm5878
asm5878 previously approved these changes Feb 20, 2025
fabiobaltieri
fabiobaltieri previously approved these changes Feb 20, 2025
dkalowsk
dkalowsk previously approved these changes Feb 27, 2025
Copy link
Contributor

@dkalowsk dkalowsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification on the milestone details. Looks like a bug fix to me

@fabiobaltieri fabiobaltieri modified the milestones: v4.1.0, v4.2.0 Mar 3, 2025
@fabiobaltieri
Copy link
Member

Hey, moving it back to 4.2, bit late for this now.

Update hal_stm32 to add the history of the released binaries
to be flashed in the Cortex-M0 coprocessor.

Signed-off-by: Nidhal BEN OTHMEN <nidhal.benothmen@st.com>
@nashif nashif merged commit fe8a089 into zephyrproject-rtos:main Mar 19, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manifest manifest-hal_stm32 size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants