twister: Remove unrecognised sections test #86257
Conversation
LukaszMrugala
force-pushed
the
remove_unrecognised_section_test
branch
from
145c029 to
1fadc1b
Compare
zephyrbot
requested review from
gchwier,
golowanow,
hakehuang,
KamilxPaszkiet,
nashif and
PerMac
| @@ -483,12 +483,6 @@ def add_parse_arguments(parser = None) -> argparse.ArgumentParser: | |||
| action="store_true", | |||
| help="Collect and report ROM/RAM section sizes for each test image built.") | |||
|
|
|||
| parser.add_argument( | |||
| "--disable-unrecognized-section-test", | |||
There was a problem hiding this comment.
Should we label this option as deprecated first in case it is actually in use somewhere downstream, and keep logging errors as warnings for the same ?
With removing just at the surface as it is currently proposed, why size_calc still tracks 'recognized' sections ?
There was a problem hiding this comment.
While normally deprecation would be in order, notice that we are removing the unrecognised section test altogether, so the --disable-[...] option is not being deprecated, but becoming the default. Anyone using this option will have the program operation proceed as expected.
Good catch, will remove the recognized key.
There was a problem hiding this comment.
so the
--disable-[...]option is not being deprecated, but becoming the default.
Anyone using this option will have the program operation proceed as expected.
with this change:
- twister will fail if this option is used somewhere, right ?
- no error logs on unrecognized sections anymore by default
There was a problem hiding this comment.
- is the default action now - the check hasn't worked for years.
- I'll add that information to the release notes.
LukaszMrugala
force-pushed
the
remove_unrecognised_section_test
branch
from
1fadc1b to
0d79e1e
Compare
LukaszMrugala
force-pushed
the
remove_unrecognised_section_test
branch
from
3845a2c to
66ec18f
Compare
The section lists that govern whether the ELF section is recognised or not are out of date. A programming bug has rendered the unrecognised section check unrunnable for years. Thus, the practically dead code of the unrecognised section check is removed in this commit. Signed-off-by: Lukasz Mrugala <lukaszx.mrugala@intel.com>
We remove the --disable-unrecognized..., so we should inform the users of that fact. Signed-off-by: Lukasz Mrugala <lukaszx.mrugala@intel.com>
LukaszMrugala
force-pushed
the
remove_unrecognised_section_test
branch
from
66ec18f to
3fa8cfc
Compare
The section lists that govern whether the ELF section is recognised or not are out of date.
A programming bug has rendered the unrecognised section check unrunnable for years.
Fix was attempted in #71051, but lack of updated section lists made the revival of the unrecognised section check counter-productive and undesired.
Thus, the practically dead code of the unrecognised section check is removed in this PR.