Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: st: add initial support for the stm32h757i eval board #86610

Merged
merged 1 commit into from
Mar 23, 2025
Merged

boards: st: add initial support for the stm32h757i eval board #86610

merged 1 commit into from
Mar 23, 2025

Conversation

tgcfoss
Copy link
Contributor

@tgcfoss tgcfoss commented Mar 4, 2025

Add initial support for the stm32h757i eval board.
Largely based on the stm32h747 disco board entry.

@zephyrbot zephyrbot added platform: STM32 ST Micro STM32 area: Shields Shields (add-on boards) labels Mar 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025

Hello @tgcfoss, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@kartben kartben assigned erwango and unassigned kartben Mar 4, 2025
nordicjm
nordicjm reviewed Mar 4, 2025
View reviewed changes
boards/st/stm32h757i_eval/dc_ram.ld
*/

#if DT_NODE_HAS_STATUS(DT_NODELABEL(sdram2), okay)
GROUP_START(SDRAM2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't going to work for people using a cmake generator @tejlmand

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something I should address? And if so, how? This part was "inherited" from the stm32h747i-disco board.

@miggazElquez
Copy link
Contributor

You should squash your commits (https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#pr-requirements)

@zephyrbot
Copy link
Collaborator

zephyrbot commented Mar 5, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@miggazElquez
Copy link
Contributor

I think you forgot to rebase on main.

@tgcfoss
Copy link
Contributor Author

tgcfoss commented Mar 10, 2025

@tgcfoss you have a minor compliance error left to fix

Fixed

@tgcfoss tgcfoss requested review from erwango and nordicjm March 10, 2025 07:54
@tgcfoss tgcfoss requested a review from nordicjm March 11, 2025 09:06
nordicjm
nordicjm previously approved these changes Mar 12, 2025
View reviewed changes
kartben
kartben previously approved these changes Mar 15, 2025
View reviewed changes
erwango
erwango requested changes Mar 17, 2025
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix reported build failures

@kartben
Copy link
Collaborator

kartben commented Mar 17, 2025

Please fix reported build failures

@erwango You're the assignee here, so it doesn't make a big difference, but please keep this in mind :)

@tgcfoss tgcfoss dismissed stale reviews from kartben and nordicjm via 84db0d2 March 17, 2025 11:44
@tgcfoss tgcfoss force-pushed the stm32h757i_eval branch 2 times, most recently from 84db0d2 to b4efe6a Compare March 17, 2025 11:56
erwango
erwango previously requested changes Mar 17, 2025
View reviewed changes
@erwango erwango self-requested a review March 17, 2025 12:14
@erwango erwango dismissed their stale review March 17, 2025 12:14

Waiting CI results.

@tgcfoss tgcfoss requested review from nordicjm and kartben March 18, 2025 07:46
@tgcfoss
boards: st: add initial support for the stm32h757i eval board
700c64e 
Add initial support for the STM32H757I-EVAL board.
Largely based on the STM32H747I-DISCO board

Signed-off-by: Tomas Groth Christensen <tgc@foss.dk>
@tgcfoss tgcfoss requested a review from nordicjm March 20, 2025 09:18
@kartben kartben merged commit 941c031 into zephyrproject-rtos:main Mar 23, 2025
23 checks passed
@github-actions GitHub Actions
Copy link

Hi @tgcfoss!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben kartben approved these changes

@erwango erwango erwango approved these changes

@avisconti avisconti Awaiting requested review from avisconti

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

@mathieuchopstm mathieuchopstm Awaiting requested review from mathieuchopstm

@LucasTambor LucasTambor Awaiting requested review from LucasTambor

@marekmatej marekmatej Awaiting requested review from marekmatej

@sylvioalves sylvioalves Awaiting requested review from sylvioalves

@nordicjm nordicjm Awaiting requested review from nordicjm

Assignees

@erwango erwango

Labels
area: Shields Shields (add-on boards) platform: STM32 ST Micro STM32
Projects
None yet
Milestone
v4.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tgcfoss @miggazElquez @zephyrbot @kartben @erwango @nordicjm