drivers: dac: Add support DAC for Renesas RA4 #86695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: DAC
zephyrbot
requested review from
duynguyenxa,
kartben,
KhiemNguyenT,
martinjaeger,
nashif,
soburi and
thaoluonguw
khoa-nguyen-18
force-pushed
the
support_renesas_ra4_dac
branch
from
38c32ee to
67a3487
Compare
khoa-nguyen-18
force-pushed
the
support_renesas_ra4_dac
branch
from
67a3487 to
c52a99e
Compare
|
Apologies for the multiple force pushes to correct the PR. It's now ready for review. |
soburi
reviewed
Mar 7, 2025
| .buffered = true | ||
| .channel_id = DAC_CHANNEL_ID, | ||
| .resolution = DAC_RESOLUTION, | ||
| #if defined(CONFIG_BOARD_EK_RA4L1) || defined(CONFIG_BOARD_EK_RA4M1) || \ |
There was a problem hiding this comment.
I think this situation may occur on other boards as well.
It seems better to add config to Kconfig.
There was a problem hiding this comment.
Thank for your suggestion, I have updated it
| defined(CONFIG_BOARD_EK_RA4W1) | ||
| .buffered = false, | ||
| #else | ||
| .buffered = true, |
There was a problem hiding this comment.
Thank you, I have updated it
khoa-nguyen-18
force-pushed
the
support_renesas_ra4_dac
branch
2 times, most recently
from
95c58f8 to
da1d271
Compare
thaoluonguw
previously approved these changes
Mar 20, 2025
Update Renesas DAC driver to support DAC for RA4 Signed-off-by: Khoa Nguyen <khoa.nguyen.xh@renesas.com>
Add support DAC for Renesas ra4-cm4 (RA4M1, RA4W1), RA4E1, RA4L1 Signed-off-by: Khoa Nguyen <khoa.nguyen.xh@renesas.com>
Add support DAC for Renesas ek_ra4m1, ek_ra4w1, fpb_ra4e1, voice_ra4e1, ek_ra4l1 Signed-off-by: Khoa Nguyen <khoa.nguyen.xh@renesas.com>
Add support test app dac_api, dac_loopback for Renesas ek_ra4l1, ek_ra4w1, ek_ra4m1 Signed-off-by: Khoa Nguyen <khoa.nguyen.xh@renesas.com>
Add support DAC for ek_ra4m1, ek_ra4w1, fpb_ra4e1, voice_ra4e1, ek_ra4l1 Signed-off-by: Khoa Nguyen <khoa.nguyen.xh@renesas.com>
khoa-nguyen-18
force-pushed
the
support_renesas_ra4_dac
branch
from
da1d271 to
3173273
Compare
|
rebase to solve the conflicts |
soburi
approved these changes
Mar 21, 2025
|
hi @martinjaeger, can you please take a look at this PR? |
thaoluonguw
approved these changes
Mar 24, 2025
kartben
reviewed
Mar 25, 2025
| @@ -10,16 +10,24 @@ include: [base.yaml] | |||
| properties: | |||
| has-internal-output: | |||
| type: boolean | |||
| description: True if the SoC supports the internal output feature in the DAC HWIP | |||
| description: | | |||
| True if the SoC supports the "internal output" feature in the DAC HWIP. | |||
There was a problem hiding this comment.
nit: using "True..." terminology is a bit ackward given this can't really be false.
Suggested change
| True if the SoC supports the "internal output" feature in the DAC HWIP. | |
| Set if the SoC supports the "internal output" feature in the DAC HWIP. |
ditto for others
There was a problem hiding this comment.
Thank you, I will update this in future DAC PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support DAC for Renesas:
ek_ra4m1
ek_ra4w1
ek_ra4l1
fpb_ra4e1
voice_ra4e1
This PR need boards: renesas: Modify the default pinsel for adc0 on ek_ra4l1 #86602 to be merged first