Bluetooth: Controller: Fix lost_payloads calculation for FT > 1 #87038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lost_payloads calculation in ull_conn_iso_start() could easily end up negative for CIS with FT > 1; Add a check to avoid this Signed-off-by: Troels Nilsson <trnn@demant.com>
zephyrbot
requested review from
carlescufi,
cvinayak,
erbr-ot,
mtpr-ot,
thoh-ot and
wopu-ot
cvinayak
approved these changes
Mar 13, 2025
|
Could this be related to #83584 ? |
Can be related if the symptom of the failure is to have a MIC failure on the very first non-zero length SDU reception after CIS is established. If there are MIC failure in subsequent SDUs, then the issue can be something else. |
The MIC error happens at the time of establishment. No SDUs are sent by the central yet when this occurs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lost_payloads calculation in ull_conn_iso_start() could easily end up negative for CIS with FT > 1; Add a check to avoid this