debug: cpu_load: Extend support to RISCV architecture and nrf54h20 #87093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Debugging
platform: nRF
zephyrbot
requested review from
anangl,
carlocaione,
edersondisouza,
fkokosinski,
jaz1-nordic,
katsuster,
kgugala,
kl-cruz,
magp-nordic,
masz-nordic,
mgielda,
nika-nordic,
npitre,
tgorochowik and
ycsin
masz-nordic
reviewed
Mar 14, 2025
nordic-krch
force-pushed
the
cpu_load_improv
branch
from
3f2b4dd to
cd1a53b
Compare
|
how did the test |
henrikbrixandersen
previously approved these changes
Mar 14, 2025
masz-nordic
previously approved these changes
Mar 14, 2025
fkokosinski
requested changes
Mar 14, 2025
There was a problem hiding this comment.
https://github.com/zephyrproject-rtos/zephyr/blob/main/tests/subsys/debug/cpu_load/testcase.yaml needs adjusting to allow RISC-V arch
nordic-krch
dismissed stale reviews from masz-nordic and henrikbrixandersen
via
e2ce4b6
nordic-krch
force-pushed
the
cpu_load_improv
branch
from
cd1a53b to
e2ce4b6
Compare
ycsin
previously approved these changes
Mar 18, 2025
nordic-krch
force-pushed
the
cpu_load_improv
branch
2 times, most recently
from
0299a36 to
318d77c
Compare
nordic-krch
force-pushed
the
cpu_load_improv
branch
from
318d77c to
b2ea432
Compare
|
@nashif @fkokosinski test filtering updated. Can you take a look? |
fkokosinski
approved these changes
Mar 19, 2025
Add sys_trace_idle_exit to RISCV cpu_idle functions and allow enabling CPU_LOAD module for RISCV and disable it for SMP. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
Allow test execution for riscv since it now supports cpu_load module. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
Add calls to sys_trace_idle and sys_trace_idle_exit in nrf54h specific idle states to allow measuring CPU load on nrf54h20 when power management is enabled. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
nordic-krch
force-pushed
the
cpu_load_improv
branch
from
b2ea432 to
e42c571
Compare
@henrikbrixandersen Done. |
henrikbrixandersen
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
sys_trace_idle_exitto RISCV cpu idle functions.Add
sys_trace_idleandsys_trace_idle_exitto nrf54h20 specific idle states.Fixes #87090.