drivers: audio: dmic_nrfx: add support for audio clocks on nRF54 #87105
+96
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstasiaknordic
force-pushed
the
nrfx_pdm_aclk
branch
from
70502ad to
e4095e0
Compare
zephyrbot
requested review from
anangl,
jaz1-nordic,
kl-cruz,
kv2019i,
lgirdwood,
lyakh,
magp-nordic,
masz-nordic,
nika-nordic and
nordic-krch
mstasiaknordic
force-pushed
the
nrfx_pdm_aclk
branch
from
e4095e0 to
f47587b
Compare
mstasiaknordic
force-pushed
the
nrfx_pdm_aclk
branch
from
f47587b to
8d0ea1e
Compare
mstasiaknordic
changed the title
mstasiaknordic
force-pushed
the
nrfx_pdm_aclk
branch
from
8d0ea1e to
4de5124
Compare
|
@mstasiaknordic please rebase on latest main to fix your ci failures |
|
@mstasiaknordic please rebase on latest main to fix your ci failures |
mstasiaknordic
force-pushed
the
nrfx_pdm_aclk
branch
6 times, most recently
from
b2c9166 to
1ff9eb2
Compare
Added binding and node for audio clock on nRF54L20 with fixed frequency of 24 MHz. Signed-off-by: Michał Stasiak <michal.stasiak@nordicsemi.no>
Added support for audio clock for nRF54L20 and AudioPLL for nRF54H20 in DMIC PDM driver. Signed-off-by: Michał Stasiak <michal.stasiak@nordicsemi.no>
mstasiaknordic
force-pushed
the
nrfx_pdm_aclk
branch
from
1ff9eb2 to
febe32a
Compare
nordic-krch
reviewed
Apr 3, 2025
| struct onoff_manager *clk_mgr; | ||
| #elif CONFIG_CLOCK_CONTROL_NRF2_AUDIOPLL | ||
| const struct device *audiopll_dev; |
There was a problem hiding this comment.
it would be better to have this in config structure as it can be initialized at compile time (contrary to clk_mgr).
nordic-segl
reviewed
Apr 9, 2025
| #else | ||
| #define DMIC_NRFX_CLOCK_FREQ MHZ(32) | ||
| #define DMIC_NRFX_CLOCK_FACTOR 4096 | ||
| #define DMIC_NRFX_AUDIO_CLOCK_FREQ \ | ||
| COND_CODE_1(CONFIG_SOC_NRF54L20, \ |
There was a problem hiding this comment.
Please consider making this target agnostic. Otherwise, future targets with audio PLL would need changes in the driver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for audio clock for nRF54L20 and AudioPLL for nRF54H20 in DMIC PDM driver.
Depends on #87471