cmake: linker: Removed unnecessary regexp in link generator #87112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
size: XS
zephyrbot
requested review from
57300,
jeremybettis,
nashif,
nordicjm and
tejlmand
tejlmand
requested changes
Mar 14, 2025
In the linker script generator there was one error checking construct that used regexp and that ended up in the generated linker file, which caused parsing problems with the IAR linker. It was unnecessary. Also updated common-rom-kernel-devices.ld. Signed-off-by: Lars-Ove Karlsson <lars-ove.karlsson@iar.com>
LoveKarlsson
force-pushed
the
iar-z-init
branch
from
8fa3a5a to
42bbf1c
Compare
tejlmand
approved these changes
Mar 18, 2025
pdgendt
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the linker script generator there was one error checking construct that used regexp and that ended up in the generated linker file, which caused parsing problems with the IAR linker. It was unnecessary.