samples/drivers/mbox: Fix test regex #87130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 9d7ee12 the regex used to verify the sample is doing what it should was changed in a way in which it cannot possibly pass. Let's fix it. While at it, in the same commit, the simulator version of the test was merged with the real_hw version, but the test name kept "real_hw" which is now missleading => let's fix it. And let's set as integration platform the simulated target, so it can actually be runtime tested in CI. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
zephyrbot
requested review from
carlocaione,
ithinuel,
kartben,
nashif and
wearyzen
hakehuang
approved these changes
Mar 17, 2025
kartben
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 9d7ee12
the regex used to verify the sample is doing what it should was changed in a way in which it cannot possibly pass.
Let's fix it.
While at it, in the same commit, the simulator version of the test was merged with the real_hw version, but the test name kept "real_hw" which is now misleading => let's fix it.
And let's set as integration platform the simulated target, so it can actually be runtime tested in CI.
To reproduce the issue run
twister -p nrf5340bsim/nrf5340/cpuapp -T samples/drivers/mbox -s sample.drivers.mbox.real_hwand see it timeout