Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: display: sdl: fixes for clear display function #87178

Merged
merged 1 commit into from
Mar 21, 2025
Merged

drivers: display: sdl: fixes for clear display function #87178

merged 1 commit into from
Mar 21, 2025

Conversation

JarmouniA
Copy link
Collaborator

@JarmouniA JarmouniA commented Mar 16, 2025 •
edited
Loading

Clear display only when display pixel format is actually supported since buffer size depends on it.

@JarmouniA JarmouniA marked this pull request as ready for review March 16, 2025 23:22
@JarmouniA JarmouniA mentioned this pull request Mar 17, 2025
Closed
@rruuaanng
Copy link
Collaborator

cc @fabiobaltieri. Oh look this.

rruuaanng
rruuaanng previously approved these changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@rruuaanng rruuaanng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JarmouniA 👍

soburi
soburi previously approved these changes Mar 17, 2025
View reviewed changes
fabiobaltieri
fabiobaltieri requested changes Mar 17, 2025
View reviewed changes
@JarmouniA JarmouniA dismissed stale reviews from soburi and rruuaanng via b0db2e5 March 17, 2025 19:32
@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Mar 17, 2025
@JarmouniA JarmouniA requested a review from fabiobaltieri March 17, 2025 19:33
fabiobaltieri
fabiobaltieri previously approved these changes Mar 17, 2025
View reviewed changes
soburi
soburi previously approved these changes Mar 17, 2025
View reviewed changes
@fabiobaltieri fabiobaltieri added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Mar 17, 2025
kartben
kartben requested changes Mar 18, 2025
View reviewed changes
@JarmouniA
drivers: display: sdl: clear display only for supported pixel formats
a6977ed 
Clear display only when display pixel format is actually supported
since buffer size depends on it.

Signed-off-by: Abderrahmane JARMOUNI <git@jarmouni.me>
@JarmouniA JarmouniA dismissed stale reviews from soburi and fabiobaltieri via a6977ed March 20, 2025 19:56
@fabiobaltieri fabiobaltieri requested a review from kartben March 21, 2025 12:44
@kartben kartben merged commit 4aaf463 into zephyrproject-rtos:main Mar 21, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben kartben approved these changes

@soburi soburi soburi approved these changes

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@faxe1008 faxe1008 faxe1008 approved these changes

@rruuaanng rruuaanng rruuaanng approved these changes

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

Assignees
No one assigned
Labels
area: Display area: Drivers size: XS A PR changing only a single line of code Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JarmouniA @rruuaanng @kartben @soburi @fabiobaltieri @faxe1008 @zephyrbot