-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: lilygo: adopt zephyr:board-supported-hw directive #87190
doc: lilygo: adopt zephyr:board-supported-hw directive #87190
Conversation
1449bb4
to
217b7b3
Compare
d420d62
to
4ce4fd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better, thank you! Just one minor remark left to make sure hierarchy is consistent for all boards. Thanks :)
4ce4fd1
to
a7e62af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually no -- please check your latest push, there is an index.rst_ file? :)
.. code-block:: console | ||
|
||
***** Booting Zephyr OS vx.x.x-xxx-gxxxxxxxxxxxx ***** | ||
Hello World! ttgo_lora32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it prints Hello World! ttgo_lora32/esp32/procpu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It indeed does:
*** Booting Zephyr OS build v4.1.0-703-ga7e62af9f56a ***
Hello World! ttgo_lora32/esp32/procpu
Why does the 'appcpu' not print 'ttgo_lora32/esp32/appcpu'?
Replace manually authored hardware features table with the new Zephyr board supported hardware directive which automatically generates an up-to-date table based on the boards' Devicetree. Removed some typos. Co-authored-by: Benjamin Cabé <benjamin@zephyrproject.org> Signed-off-by: Lothar Felten <lothar.felten@gmail.com>
a7e62af
to
ac710b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have been better to have the different set of changes in different commits but I can live with that :)
Replace manually authored hardware features table with the new Zephyr board supported hardware directive which automatically generates an up-to-date table based on the boards' Devicetree.
https://builds.zephyrproject.io/zephyr/pr/87190/docs/boards/index.html#vendor=lilygo