Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: lilygo: adopt zephyr:board-supported-hw directive #87190

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

lfelten
Copy link
Contributor

@lfelten lfelten commented Mar 17, 2025

Replace manually authored hardware features table with the new Zephyr board supported hardware directive which automatically generates an up-to-date table based on the boards' Devicetree.

https://builds.zephyrproject.io/zephyr/pr/87190/docs/boards/index.html#vendor=lilygo

@lfelten lfelten force-pushed the lilygo_board_supported_hw branch from 1449bb4 to 217b7b3 Compare March 17, 2025 09:50
@lfelten lfelten force-pushed the lilygo_board_supported_hw branch 2 times, most recently from d420d62 to 4ce4fd1 Compare March 17, 2025 11:44
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, thank you! Just one minor remark left to make sure hierarchy is consistent for all boards. Thanks :)

@lfelten
Copy link
Contributor Author

lfelten commented Mar 17, 2025

@kartben fixed some typos mentioned in PR #87149 too

Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually no -- please check your latest push, there is an index.rst_ file? :)

.. code-block:: console

***** Booting Zephyr OS vx.x.x-xxx-gxxxxxxxxxxxx *****
Hello World! ttgo_lora32
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it prints Hello World! ttgo_lora32/esp32/procpu

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It indeed does:
*** Booting Zephyr OS build v4.1.0-703-ga7e62af9f56a ***
Hello World! ttgo_lora32/esp32/procpu

Why does the 'appcpu' not print 'ttgo_lora32/esp32/appcpu'?

Replace manually authored hardware features table with the new Zephyr
board supported hardware directive which automatically generates an
up-to-date table based on the boards' Devicetree.
Removed some typos.

Co-authored-by: Benjamin Cabé <benjamin@zephyrproject.org>

Signed-off-by: Lothar Felten <lothar.felten@gmail.com>
@lfelten lfelten force-pushed the lilygo_board_supported_hw branch from a7e62af to ac710b2 Compare March 18, 2025 00:20
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have been better to have the different set of changes in different commits but I can live with that :)

@kartben kartben merged commit e4679e4 into zephyrproject-rtos:main Mar 19, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants