Ambiq cache update #87252
Merged
Ambiq cache update #87252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds cache support for ambiq spic driver Signed-off-by: Hao Luo <hluo@ambiq.com>
This commit adds cache support for ambiq i2c driver Signed-off-by: Hao Luo <hluo@ambiq.com>
zephyrbot
requested review from
aaronyegx,
RichardSWheatley,
tbursztyka and
teburd
swift-tk
reviewed
Mar 18, 2025
There was a problem hiding this comment.
I would suggest that we would provide a kconfig option to enable and disable cache handling in the driver if user would like to handle it up top.
We should also force the cmdq buffer alignment and put it in noncacheable region to leave it out of cache handling. The .nocache does not guarantee alignment nor location.
aaronyegx
approved these changes
Mar 19, 2025
RichardSWheatley
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cache support for ambiq drivers