Bluetooth: Host: Fix format specifier warnings #87262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth
area: Bluetooth Host
zephyrbot
requested review from
alwa-nordic,
cvinayak,
hermabe,
rugeGerritsen,
sjanc,
Thalley and
theob-pro
jhedberg
added
the
Trivial
|
This was reported here: #82316 (comment) |
hermabe
previously approved these changes
Mar 18, 2025
|
Thanks for addressing the issue. But it seems CI does not show the full log; the issue occurs in many places! Let me share the full warnings when I build locally. I am not sure that fixing only Build command: |
|
@nhutnguyenkc I've pushed an update to try to fix all of those. Can you confirm if all the warnings/errors are now gone for you? |
zephyrbot
requested review from
gzh-terry,
lylezhu2012,
makeshi and
MarkWangChinese
jhedberg
changed the title
Thalley
previously approved these changes
Mar 18, 2025
Comment on lines
+1548
to
1549
| LOG_ERR("Too small RFCOMM information (%u < %zu)", buf->len, | ||
| hdr_len + msg_len + sizeof(fcs)); |
There was a problem hiding this comment.
Does adding a non-size_t with a size_t always result in a size_t?
There was a problem hiding this comment.
I think the compiler will round up to the biggest type in the calculation, which in this case is size_t
It has improved a lot. Only two warnings remain. |
lylezhu2012
previously approved these changes
Mar 18, 2025
Use %zu for size_t and %zd for ssize_t, and don't use those specifiers for any other type. Also make sure that field width specifiers get typecast to the expected int type. Signed-off-by: Johan Hedberg <johan.hedberg@silabs.com>
Those remaining two should be fixed now. Could you verify? |
Thalley
approved these changes
Mar 18, 2025
Now all of them have been gone! |
nhutnguyenkc
approved these changes
Mar 18, 2025
|
@hermabe @lylezhu2012 please refresh your reviews (that were dismissed due to fixing a couple more format string issues), thanks! |
lylezhu2012
approved these changes
Mar 18, 2025
hermabe
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use %zu for size_t and %zd for ssize_t, and don't use those specifiers for any other type. Also make sure that field width specifiers get typecast to the expected int type.