tests/bsim/run_parallel: Fail if an explicitly listed test is missing & fix missing tests #87282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth
area: Bluetooth Host
zephyrbot
requested review from
alwa-nordic,
hermabe,
jhedberg,
rugeGerritsen,
sjanc and
theob-pro
Thalley
previously approved these changes
Mar 18, 2025
cvinayak
requested changes
Mar 18, 2025
tests/bsim/bluetooth/ll/bis/tests_scripts/broadcast_iso.sh was split in two in 872b193 but for the 54L15 and 5340 it was forgotten in the list of tests to run. Let's fix it. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
We never got to add any multidevice tests to the UART driver tests. So let's not try to run that empty set in CI. (we have some multidevice UART tests for BT). Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
aescolar
force-pushed
the
bsim_error_onfind
branch
2 times, most recently
from
6d6af15 to
aa4e8d1
Compare
cvinayak
approved these changes
Mar 19, 2025
jhedberg
previously approved these changes
Mar 19, 2025
cvinayak
requested changes
Mar 19, 2025
Instead of just printing a warning, fail (return != 0 to the shell) if a test is missing, or a pattern does not match any test. Also, warn (and return != 0) if no tests are found when SEARCH_PATH is provided. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
aescolar
force-pushed
the
bsim_error_onfind
branch
from
aa4e8d1 to
639e21d
Compare
cvinayak
approved these changes
Mar 20, 2025
Github's Copilot can provide additional explanation: |
Thalley
approved these changes
Mar 20, 2025
jhedberg
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just printing a warning, fail (return != 0 to the shell) if a test is missing, or a pattern does not match any test
tests/bsim/bluetooth/ll/bis/tests_scripts/broadcast_iso.sh was split in two in 872b193 but for the 53 and 5340 it was forgotten in the list of tests to run.
Let's fix it.