Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: we: correct board name #87285

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

mah-eiSmart
Copy link
Contributor

correct board name in documentation

correct board name in documentation

Signed-off-by: Matthias Hauser <matthias.hauser@we-online.de>
@mah-eiSmart
Copy link
Contributor Author

@jhedberg hey, how are reviewers assigned to my PR? This one is really trivial.

@jhedberg
Copy link
Member

how are reviewers assigned to my PR?

This has to be done manually, since there's no entry for boards/we in MAINTAINERS.yml. In practice you either need to ping someone in a PR comment (like you now did) or ask for help on the #pr-help channel on Discord.

@mah-eiSmart
Copy link
Contributor Author

how are reviewers assigned to my PR?

This has to be done manually, since there's no entry for boards/we in MAINTAINERS.yml. In practice you either need to ping someone in a PR comment (like you now did) or ask for help on the #pr-help channel on Discord.

Thank you @jhedberg , I did not know that. I believe this year we are able to join the group of maintainers as well. Just for curiosity: How can we mark a certain account as maintainer? Add it to the maintainer file and let the Maureen or Nash decide if they accept it?

@mah-eiSmart
Copy link
Contributor Author

@kartben thank you for the approval. Can this PR be merged now, or what does "You're not authorized to push to this branch." mean?

@kartben
Copy link
Collaborator

kartben commented Mar 19, 2025

how are reviewers assigned to my PR?

This has to be done manually, since there's no entry for boards/we in MAINTAINERS.yml. In practice you either need to ping someone in a PR comment (like you now did) or ask for help on the #pr-help channel on Discord.

Thank you @jhedberg , I did not know that. I believe this year we are able to join the group of maintainers as well. Just for curiosity: How can we mark a certain account as maintainer? Add it to the maintainer file and let the Maureen or Nash decide if they accept it?

I would encourage a few of you to first step up as Contributors -- this way your reviews will start actually counting (green mark vs. grey mark), and it's one step closer to becoming maintainer(s)
See nomination form here: https://github.com/zephyrproject-rtos/zephyr/issues/new?assignees=&labels=Role+Nomination&projects=&template=006_nomination.md&title=

Next step would be for WE to identify who would want to be the maintainer (and potentially identify a couple collaborators) and then send a PR updating the MAINTAINERS.yml file indeed.

@kartben
Copy link
Collaborator

kartben commented Mar 19, 2025

@kartben thank you for the approval. Can this PR be merged now, or what does "You're not authorized to push to this branch." mean?

Only release managers have the permissions to merge, and pull requests typically need to be in review for a minimum of 2 business days.
https://docs.zephyrproject.org/latest/project/project_roles.html#merge-criteria

@kartben kartben merged commit 2c08244 into zephyrproject-rtos:main Mar 20, 2025
17 checks passed
@mah-eiSmart
Copy link
Contributor Author

@kartben , thank you! And also to @nordicjm for review and, @jhedberg for review and help/clarification!

@mah-eiSmart mah-eiSmart deleted the orthosie1evName branch March 27, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants