drivers/sensor/ite/tach_ite_it8xxx2: don't clear both status at once #87326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
asemjonovs,
avisconti,
brockus-zephyr,
Dino-Li,
GTLin08,
jackrosenthal,
jeppenodgaard,
keith-zephyr,
MaureenHelm,
sjg20,
teburd,
tristan-google,
ubieda and
yperess
ubieda
requested changes
Mar 19, 2025
RuibinChang
force-pushed
the
it8xxx2_tach
branch
2 times, most recently
from
304dcf0 to
04476e1
Compare
Done, split into two commits. |
…once When two tach use simultaneously, I find that the both tach status will be cleared at once, which causes one of tach not to get rpm speed. So I change it to clear status only one tach at a time. This issue is reported by Huaqin: https://partnerissuetracker.corp.google.com/issues/404067663?pli=1 Signed-off-by: Ruibin Chang <Ruibin.Chang@ite.com.tw>
RuibinChang
force-pushed
the
it8xxx2_tach
branch
from
04476e1 to
917d4c2
Compare
Run clang format. Signed-off-by: Ruibin Chang <Ruibin.Chang@ite.com.tw>
|
use existing macro |
ubieda
approved these changes
Mar 20, 2025
yperess
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two tach use simultaneously, we find that both tach status will be cleared at once, which causes one of tach not to get r.p.m.
So I change it to clear status only one tach at a time, and also run clang format.
This issue is reported by Huaqin:
https://partnerissuetracker.corp.google.com/issues/404067663?pli=1