net: core: Do IPv4/6 packet checks only for those packet types #87328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check_ip() in net_core.c did not check that the packet Ethernet type is either IPv4 or IPv6. This meant that we for example checked TTL also for ARP packets which is pointless as those are not IPv4 packets. Fix this by checking the link layer protocol type of the packet to be either IPv4 or IPv6 before doing L3 checks. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
pdgendt
previously approved these changes
Mar 19, 2025
rlubos
previously approved these changes
Mar 19, 2025
|
pdgendt
approved these changes
Mar 19, 2025
rlubos
approved these changes
Mar 19, 2025
The test_send_ipv6_fragment_without_hbho() test did not set link layer protocol type for the packet. It is needed in this case because we are sending a ready made packet and the protocol type is unknown otherwise. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
jukkar
force-pushed
the
fix/87327/ll-ptype-not-checked-in-sending
branch
from
20c32e3 to
a3771cb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check_ip() in net_core.c did not check that the packet Ethernet type is either IPv4 or IPv6. This meant that we for example checked TTL also for ARP packets which is pointless as those are not IPv4 packets.
Fix this by checking the link layer protocol type of the packet to be either IPv4 or IPv6 before doing L3 checks.
Fixes #87327