drivers: rtc: pcf8563: minor fixes to the driver #87336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drivers/rtc/rtc_pcf8563.c
Outdated
| #ifdef PCF8563_INT1_GPIOS_IN_USE | ||
| /* The logic related to the pin interrupt logic */ | ||
|
|
||
| void callback_work_handler(struct k_work *work) |
There was a problem hiding this comment.
please add static keyword to the functions as well, with this, the warning would likely have been caught faster :)
- Define alarm_set_callback() only when CONFIG_RTC_ALARM is set otherwise a warning will be generated at runtime for the function not being used. - add "static" keyword to all internal functions. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
valeriosetti
force-pushed
the
fix-rtc-alarm-callback
branch
from
0e683f0 to
c4f938d
Compare
valeriosetti
changed the title
JordanYates
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define alarm_set_callback() only when CONFIG_RTC_ALARM is set otherwise
a warning will be generated at runtime for the function not being
used.
add "static" keyword to all internal functions.