video: drivers misc fixes #87366
Open
video: drivers misc fixes #87366
+106
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Shields
zephyrbot
requested review from
avisconti,
dbaluta,
decsny,
dleach02,
erwango,
fabiobaltieri,
galak,
jfischer-no,
josuah,
kartben,
loicpoulain,
manuargue,
mbolivar,
mmahadevan108 and
Raymond0225
|
@josuah : The video emul imager exposes 3 controls : VIDEO_CID_EXPOSURE, VIDEO_CID_GAIN and VIDEO_CID_TEST_PATTERN. However, it does nothing specific to each control type, just a "fake" register write (?). I know this is just for testing purpose but even if this is just an emulation, we need to emul something "real". If not, it will be very difficult to rework the video control framework as each control type needs a specific implementation. I am going to remove these controls in the driver and just keep 1 control of type "vendor-specific" as an emulated read/write. Is it ok for you to do that ? |
|
I added that commit here: db5abeb Also available as a stand-alone commit on top of this Whichever is most convenient! Tested with: |
josuah
reviewed
Mar 19, 2025
josuah
previously approved these changes
Mar 19, 2025
The MIPI CSI-2 Rx needs to be initialized after the camera sensor which is generally initialized with CONFIG_VIDEO_INIT_PRIORITY. This is currently true "by chance" due to the order the linker links the object files. This linker order is not easily controlled, so use an explicit priority value to ensure this requirement. Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
Aptina was acquired by Onsemi for a long time. Fix the company name prefix and compatible string. Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
Fix coding style in a variable naming. Signed-off-by: Farah Fliss <farah.fliss@nxp.com> Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
The mt9m114 camera driver used to be single-instance. Improve it to multi-instance. Signed-off-by: Farah Fliss <farah.fliss@nxp.com> Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
Modify the pixel rate type to uint32_t which is sufficient to support pixel rates range. Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com> Signed-off-by: Trung Hieu Le <trunghieu.le@nxp.com>
Change pixel rate type to uint32_t which is sufficient to support pixel rates range. Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com> Signed-off-by: Trung Hieu Le <trunghieu.le@nxp.com>
Separate autogain and gain controls. This type of controls depend on each other and will be supported as "control group" in the new video control framework. Signed-off-by: Trung Hieu Le <trunghieu.le@nxp.com> Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
SDE_CTRL8_REG's value must be modified using modify_register. Signed-off-by: Trung Hieu Le <trunghieu.le@nxp.com> Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
Fix the sign register for brightness control Signed-off-by: Trung Hieu Le <trunghieu.le@nxp.com> Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
Fix sign's register for constrast value. Signed-off-by: Trung Hieu Le <trunghieu.le@nxp.com> Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
The Emul Rx needs to be initialized after the camera sensor which is generally initialized with CONFIG_VIDEO_INIT_PRIORITY. This is currently true "by chance" due to the order the linker links the object files. This linker order is not easily controlled, so use an explicit priority value to ensure this requirement. Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
ngphibang
force-pushed
the
video_driver_misc_fixes
branch
from
00869da to
1b501e5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some misc fixes on video drivers, especially on the controls parts. This is to prepare to implement correctly each control type in the upcomming video control framework.