-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: intc: esp32: Shared allocator for Xtensa and RISCV #87369
Open
raffarost
wants to merge
5
commits into
zephyrproject-rtos:main
Choose a base branch
from
raffarost:improve/intc_esp32_common_irq
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
drivers: intc: esp32: Shared allocator for Xtensa and RISCV #87369
raffarost
wants to merge
5
commits into
zephyrproject-rtos:main
from
raffarost:improve/intc_esp32_common_irq
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
879b612
to
fb16e24
Compare
Shared allocator for Xtensa and RISCV Signed-off-by: Raffael Rostagno <raffael.rostagno@espressif.com>
Update IRQ handling related files to unify interrupt controller between Xtensa and RISCV devices. Signed-off-by: Raffael Rostagno <raffael.rostagno@espressif.com> Signed-off-by: Sylvio Alves <sylvio.alves@espressif.com>
fb16e24
to
6817f05
Compare
Update interrupt allocator to use the same driver for both Xtensa and RISCV devices. Signed-off-by: Raffael Rostagno <raffael.rostagno@espressif.com> Signed-off-by: Sylvio Alves <sylvio.alves@espressif.com>
Drivers update to use shared interrupt allocator for Xtensa and RISCV devices. Signed-off-by: Raffael Rostagno <raffael.rostagno@espressif.com> Signed-off-by: Sylvio Alves <sylvio.alves@espressif.com>
Update driver for unified interrupt allocator (Xtensa/RISCV), to allow using shared interrupts. Signed-off-by: Raffael Rostagno <raffael.rostagno@espressif.com>
6817f05
to
c306229
Compare
sylvioalves
reviewed
Mar 26, 2025
@@ -244,7 +244,7 @@ static int esp32_ipm_init(const struct device *dev) | |||
ESP_PRIO_TO_FLAGS(cfg->irq_priority_app_cpu) | | |||
ESP_INT_FLAGS_CHECK(cfg->irq_flags_app_cpu) | | |||
ESP_INTR_FLAG_IRAM, | |||
(intr_handler_t)esp32_ipm_isr, | |||
esp32_ipm_isr, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is casting needed here? (intr_handler_t)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update interrupt allocator to use the same driver for both Xtensa and RISCV devices.