Silabs siwx91x dma driver scatter gather feature and other fixes/improvements #87383
+283
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Corrected the burst length processing to be handled in bytes for the siwx917 DMA drivers. 2. Removed overlay and configuration files associated with the chan_blen_transfer test application. The chan_blen_transfer test application attempted to use 8 and 16 byte bursts, which are not supported by the siwx91x UDMA. Signed-off-by: Sai Santhosh Malae <Santhosh.Malae@silabs.com>
Refactored the driver code to ensure compatibility with the dma_context API, improving maintainability and consistency with other DMA drivers in the Zephyr project. Signed-off-by: Sai Santhosh Malae <Santhosh.Malae@silabs.com>
zephyrbot
requested review from
asmellby,
jerome-pouiller,
jhedberg,
Martinhoff-maker and
teburd
nordicjm
requested changes
Mar 20, 2025
drivers/dma/dma_silabs_siwx91x.c
Outdated
| ARG_UNUSED(dev); | ||
|
|
||
| if (filter_param != NULL) { | ||
| if ((int)*((int *)filter_param) == channel) { |
There was a problem hiding this comment.
There is no need to cast filter_param twice: return (*(int *)filter_param == channel);.
drivers/dma/dma_silabs_siwx91x.c
Outdated
| return false; | ||
| } | ||
| } | ||
| return 0; |
There was a problem hiding this comment.
Since the prototype declare a bool, prefer return false;.
BTW, you can handle exception first and remove a level of indentation:
if (!filter_param) {
return false;
}
[...]
drivers/dma/dma_silabs_siwx91x.c
Outdated
| status = siwx91x_channel_config(dev, udma_handle, channel, config); | ||
| if (config->head_block->next_block != NULL) { | ||
| /* Configure DMA for a Scatter-Gather transfer */ | ||
| status = siwx91x_sg_config(dev, udma_handle, channel, config); |
There was a problem hiding this comment.
We have to check somewhere if the caller set complete_callback_en and returns an error on this case.
drivers/dma/dma_silabs_siwx91x.c
Outdated
| /* Configure DMA for a Scatter-Gather transfer */ | ||
| status = siwx91x_sg_config(dev, udma_handle, channel, config); | ||
| } else { | ||
| status = siwx91x_channel_config(dev, udma_handle, channel, config); |
There was a problem hiding this comment.
siwx91x_channel_config() and siwx91x_sg_config() are "sibling" functions. I would try reflect this link in their names. eg. siwx91x_direct_chan_config()/siwx91x_sg_chan_config(), siwx91x_chan_cfg_contiguous()/siwx91x_chan_cfg_sg(), ...
There was a problem hiding this comment.
Changed the names accordingly
drivers/dma/dma_silabs_siwx91x.c
Outdated
| @@ -33,6 +36,7 @@ enum { | |||
| struct dma_siwx91x_channel_info { | |||
| dma_callback_t dma_callback; /* User callback */ | |||
| void *cb_data; /* User callback data */ | |||
| uint32_t sg_desc_addr_info; /* Scatter-Gather table start address */ | |||
There was a problem hiding this comment.
I believe sg_desc_addr_info should be a RSI_UDMA_DESC_T *.
There was a problem hiding this comment.
Agreed. Updated the type.
smalae
force-pushed
the
silabs_siwx91x_dma_driver_SG_feature_and_fixes
branch
from
2c25fc7 to
1646510
Compare
This new API allows the assignment of desired DMA channels for peripheral transfers, enhancing flexibility and control over DMA operations. Signed-off-by: Sai Santhosh Malae <Santhosh.Malae@silabs.com>
Updated the driver to ensure that each DMA channel can properly assign and handle individual callbacks. Signed-off-by: Sai Santhosh Malae <Santhosh.Malae@silabs.com>
Implement support for scatter-gather DMA transfers in the siwx917 driver. This enhancement allows the driver to handle multiple non-contiguous memory buffers in a single DMA transaction Signed-off-by: Sai Santhosh Malae <Santhosh.Malae@silabs.com>
smalae
force-pushed
the
silabs_siwx91x_dma_driver_SG_feature_and_fixes
branch
from
1646510 to
7fd8b45
Compare
jerome-pouiller
approved these changes
Mar 20, 2025
jhedberg
approved these changes
Mar 20, 2025
|
@nordicjm, I believe your comment has been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the siwx917 DMA drivers.
chan_blen_transfer test application. The chan_blen_transfer
test application attempted to use 8 and 16 byte bursts, which
are not supported by the siwx91x UDMA.
assign and handle individual callbacks.