Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: spi: cc13xx_cc26xx: Allow clocks below 2 MHz #87400

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

dlim04
Copy link
Contributor

@dlim04 dlim04 commented Mar 20, 2025

Remove unnecessary check that the SPI clock is being set to a frequency above 2 MHz to allow devices running at common lower frequencies (i.e. 1.2 MHz and 400 kHz).

Replace with check that the frequency is not below the minimum frequency supported by the chipset to prevent overflow error which can occur if the HAL sets a frequency too low resulting in a SPI clock much larger than expected.

Fixes #69986

Copy link

Hello @dlim04, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Remove unnecessary check that the SPI clock is being set to a frequency
above 2 MHz to allow devices running at common lower frequencies (i.e.
1.2 MHz and 400 kHz).

Replace with check that the frequency is not below the minimum frequency
supported by the chipset to prevent overflow error which can occur if
the HAL sets a frequency too low resulting in a SPI clock much larger
than expected.

Fixes zephyrproject-rtos#69986

Signed-off-by: David Lim <dlim04@qub.ac.uk>
@dlim04 dlim04 force-pushed the 69986_fix_cc13xx_cc26xx_spi branch from 75fb20f to f2b0369 Compare March 20, 2025 12:40
@kartben kartben merged commit 459a078 into zephyrproject-rtos:main Mar 24, 2025
21 checks passed
Copy link

Hi @dlim04!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@dlim04 dlim04 deleted the 69986_fix_cc13xx_cc26xx_spi branch March 24, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: SPI SPI bus platform: TI SimpleLink Texas Instruments SimpleLink MCU
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drivers: spi: cc13xx_cc26xx.c: Doesn't Allow SPI Serial Clock Lower Than 2MHz
6 participants