drivers: adc: nrfx_saadc: Add channel configuration validation for nrf54h20 #87405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On nrf54h20 there are additional analog pins (AIN8+). When differential mode is used they must not be mixed with AIN0-AIN7. Add build time validation which detects if configuration is invalid. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
Sample is reading vref-mv property to get reference voltage and then if reference source is set to ADC_REF_INTERNAL this value is overwritten. If vref-mv property is provided then it should not be overwritten. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
zephyrbot
added
area: Samples
zephyrbot
requested review from
jaz1-nordic,
kartben,
kl-cruz,
magp-nordic,
masz-nordic,
nashif and
nika-nordic
AIN9 source needs special handling (all from AIN8-AIN14). Conversion result needs to be scaled up by 3.6 additionally to gain and reference voltage. In order to achieve correct value in the sample vref-mv is used as reference voltage instead of predefined internal reference source. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nrf54h20 has AIN8-AIN14 sources which require special handling:
When differential mode is used then AIN0-7 cannot be mixed with AIN8-13.
PR adds channel validation macro which checks at compile time if differential channel configuration is correct.
Result must be multiplied by 3.6 to get the actual value
There is no good way of adding 3.6 multiplier in the driver so only sample is modified. Channel that is using AIN8-AIN14 sources shell use
vref-mvproperty set toreferece_mv * 3.6.