drivers: nxp: wifi: Disable softap mode by default

[jukkar]

Do not enable CONFIG_NXP_WIFI_SOFTAP_SUPPORT by default as that should be let for the user to decide whether the AP mode is compiled or not.

[jukkar]

I am trying to use frdm_rw612 for testing wifi things. I tried to compile zperf sample but got hit by this issue as the AP mode was enabled by default even if I did not want that. IMHO AP mode selection should be left for the user of the board and not something that is enabled by default.

[jukkar]

I have couple of notes:

• Why the application needs to enable CONFIG_NXP_WIFI_SOFTAP_SUPPORT which then selects CONFIG_WIFI_NM_HOSTAPD_AP symbol. I think this should be reversed so that the driver has depends on WIFI_NM_HOSTAPD_AP so that if user wants to enable AP mode, the driver enables suitable options for itself. With the current way of working, one needs to enable the NXP specific option in the board file or somewhere else to enable the AP mode. So what I am looking after here is that the user enables features in its config, then the drivers/boards etc. enable its internal symbols if needed by depending on those more generic feature config options.
• Why is wifi not enabled by default for this board. If user has this board and enables CONFIG_NETWORKING we should/could enable wifi automatically by the board config as that kind of implies that user wants to have networking support.
• We should support wifi snippets also for this board, I am investigating this in order to simplify testing.

[gannicus-gj]

Hi @jukkar
AP mode is mandatory feature for NXP Wi-fi. NXP (Customer/QA) needs AP mode enabled by default for
daily sanity test, regression test and release milestone. Users that does not need it can disable it based on their case
, so could you pls keep this feature enabled by default？

[jukkar]

NXP (Customer/QA) needs AP mode enabled by default for daily sanity test, regression test and release milestone.

But that is the application feature, not a driver feature. About the QA, it is just another user of the board using for example frdm_rw612, and it should enable the AP mode if it needs it. Please note that the various configurations for drivers and boards etc. should be generic and not tailored to some vendor use case. So all the options you need for QA, should be set via some out-of-tree way when building, typically there should be a overlay file that gets used when your QA builds an app with this wifi driver.

[krish2718]

So all the options you need for QA, should be set via some out-of-tree way when building, typically there should be a overlay file that gets used when your QA builds an app with this wifi driver.

or you can have various samples/applications. If a customer wants every feature enabled, you can have an application nxp_wifi_superset and in that prj.conf enable all features.

[MaochenWang1]

I tried to compile zperf sample but got hit by this issue as the AP mode was enabled by default even if I did not want that

Hi @jukkar Does the AP default enabled have any side effect? what's your build cmd?

[MaochenWang1]

• Why is wifi not enabled by default for this board. If user has this board and enables CONFIG_NETWORKING we should/could enable wifi automatically by the board config as that kind of implies that user wants to have networking support.

Hi @jukkar but this board also supports BLE only mode, so wifi should not be enabled by default, right?

• We should support wifi snippets also for this board

what's the wifi snippets do you mean?

[dleach02]

@MaochenWang1 did you resolve your concerns in the bi-weekly sync call? If so please +1 this PR

[MaochenWang1]

@MaochenWang1 did you resolve your concerns in the bi-weekly sync call? If so please +1 this PR

I will create a new PR to clean the rw612 conf and move this CONFIG_NXP_WIFI_SOFTAP_SUPPORT to a rw612 overlay, then I will give this PR +1