drivers: serial: uart_mcux_lpuart: add DTR, DSR, and DCD signals #87416
+115
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekSnell
added
area: UART
zephyrbot
requested review from
dbaluta,
dcpleung,
decsny,
dleach02,
manuargue,
mmahadevan108 and
Raymond0225
EmilioCBen
previously approved these changes
Mar 20, 2025
dcpleung
previously approved these changes
Mar 20, 2025
decsny
previously requested changes
Mar 20, 2025
DerekSnell
force-pushed
the
LPUART_line_control
branch
2 times, most recently
from
d3c2854 to
7af5b29
Compare
Thank you @decsny for your feedback. My code was messy, and your suggestions do improve the readability. Please let me know how this looks to you know. Thanks |
decsny
reviewed
Mar 20, 2025
Add support for additional line control signals. Improved configuring uart_config_flow_control options. Signed-off-by: Derek Snell <derek.snell@nxp.com>
DerekSnell
force-pushed
the
LPUART_line_control
branch
from
7af5b29 to
7916b21
Compare
|
@abhinavnxp and @nirav-agrawal , FYI Since you are using HW flow control with modules and the line control APIs in LPUART, be aware of this update to the driver. Feel free to test out this update. Best regards |
decsny
approved these changes
Mar 21, 2025
dcpleung
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for additional line control signals. Improved configuring uart_config_flow_control options.
Removed macro UART_LINE_CTRL_ENABLE because some line control signals in the LPUART do not depend on FSL_FEATURE_LPUART_HAS_MODEM_SUPPORT. Added LPUART_HAS_MODEM instead.