Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: boards: Add mco support for nucleo_wl55jc board #87420

Merged
merged 3 commits into from
Mar 24, 2025

Conversation

Martdur
Copy link
Contributor

@Martdur Martdur commented Mar 20, 2025

Description

This PR add mco support for stm32wl, and adapt the sampel for nucleo_wl55jc

Test steps

  • Run the mco sample using nucleo_wl55jc and check the signal on the mco pin (PA8).

Signed-off-by: Martdur martin.durietz@gmail.com

Copy link
Collaborator

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM functionally. Please address issues raised by CI and the following:

@Martdur Martdur force-pushed the feature/mco-support-stm32wl branch from 2893a22 to b50ec4f Compare March 21, 2025 10:14
@Martdur
Copy link
Contributor Author

Martdur commented Mar 21, 2025

  • Fix indentation CI in samples/boards/st/mco/sample.yaml
  • Remove space in samples/boards/st/mco/boards/nucleo_wl55jc.overlay
  • Move CFGR1_REG to a better location
  • Change clock definition comment in overlay file

mathieuchopstm
mathieuchopstm previously approved these changes Mar 21, 2025
Martdur added 2 commits March 21, 2025 16:13
Added MCO register definition to support MCO functionality in the STM32WL
series. This update also includes the addition of MCO_PRE_DIV and MCO_SEL
defines.

Signed-off-by: Martin Durietz <martin.durietz@gmail.com>
Added MCO1 peripheral definition to the STM32WL device tree to enable
MCO functionality.

Signed-off-by: Martin Durietz <martin.durietz@gmail.com>
mathieuchopstm
mathieuchopstm previously approved these changes Mar 24, 2025
Copy link
Collaborator

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch of missing newline.
Minor cosmetic nits, but LGTM otherwise:

erwango
erwango previously approved these changes Mar 24, 2025
Added overlay and modified sample.yaml to support the nucleo_wl55jc
board in the MCO example.

Signed-off-by: Martin Durietz <martin.durietz@gmail.com>
@Martdur Martdur dismissed stale reviews from erwango and mathieuchopstm via 4c0c995 March 24, 2025 09:06
@Martdur Martdur force-pushed the feature/mco-support-stm32wl branch from cd4c755 to 4c0c995 Compare March 24, 2025 09:06
@Martdur
Copy link
Contributor Author

Martdur commented Mar 24, 2025

Linter in samples/boards/st/mco/boards/nucleo_wl55jc.overlay

@erwango erwango assigned erwango and unassigned nordic-krch Mar 24, 2025
@kartben kartben merged commit 022903f into zephyrproject-rtos:main Mar 24, 2025
21 checks passed
Copy link

Hi @Martdur!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants