net: sntp: Added timezone support on sntp #87434
Conversation
It was added timezone feature on handling SNTP request to synchronize system clock of the device according to global time requested. Signed-off-by: Pedro Ramos <pedrohq.r@hotmail.com>
zephyrbot
requested review from
jukkar,
pdgendt,
rlubos,
ssharks and
tbursztyka
|
Hello @pedrohqr, and thank you very much for your first pull request to the Zephyr project! |
| @@ -226,6 +226,16 @@ config NET_CONFIG_SNTP_INIT_SERVER | |||
| e.g. server information at | |||
| https://support.ntp.org/bin/view/Servers/NTPPoolServers | |||
|
|
|||
| config NET_CONFIG_SNTP_TIMEZONE | |||
| bool "Enable timezone control for system clock" | |||
| default n | |||
There was a problem hiding this comment.
Options are off by default so we typically do not mention this, so this line can be removed.
| @@ -48,7 +59,11 @@ int net_init_clock_via_sntp(void) | |||
| goto end; | |||
| } | |||
|
|
|||
| tspec.tv_sec = ts.seconds; | |||
| #if CONFIG_NET_CONFIG_SNTP_TIMEZONE | |||
| tspec.tv_sec = ts.seconds - (UTC_0 - global_tz) * 3600; | |||
There was a problem hiding this comment.
There is now some misunderstanding how timezones are used. So typically the internal clock is kept in UTC_0 but when presenting the time to the user, the timezone is taken into account and tweaked accordingly. This way for example DST handling is very easy as the internal clock does not need any tweaking when that happens.
So with this in mind, this PR is doing things that are not really needed.
| @@ -14,4 +14,6 @@ if(CONFIG_NET_CONFIG_SETTINGS) | |||
| ) | |||
| endif() | |||
|
|
|||
| zephyr_library_sources_ifdef(CONFIG_NET_CONFIG_CLOCK_SNTP_INIT init_clock_sntp.c) | |||
| zephyr_include_directories(.) | |||
There was a problem hiding this comment.
Internal headers shouldn't be exposed globally, whatever needs to be exposed for the app should be placed in a public header.
|
|
||
| void sntp_set_timezone(const enum timezone tz) | ||
| { | ||
| global_tz = tz; |
There was a problem hiding this comment.
Note that Zephyr uses tabs for indentation.
It was added timezone feature on handling SNTP request to synchronize system clock of the device according to global time requested. In Kconfig was added
NET_CONFIG_CLOCK_SNTP_INITbool option were, on enable, include enum timezone in the code, allowing user calling forsntp_set_timezone()and set the global timezone offset of the current device.